Fix clang errors in 9on12Adapter.cpp#113
Merged
jenatali merged 1 commit intoJun 13, 2026
Merged
Conversation
Fixes three clang-cl errors surfaced when building under USE_CLANG=1, all in Adapter::Adapter: * CComQIPtr<T> p = pAdapterIUnknown -> pAdapterIUnknown.p (lines 234, 245) Clang refuses two chained user-defined conversions; using .p makes the IUnknown* conversion explicit. * &m_pD3D12Device->GetAdapterLuid() -> stash LUID in a local first (line 261) Clang -Waddress-of-temporary; GetAdapterLuid() returns by value. Byte-identical behavior on MSVC; validated against an OS enlistment by building onecoreuap\windows\DirectX\dxg\inactive\d3d9\d3d9on12 under both USE_CLANG=1 and MSVC. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ruiji-shi
changed the title
winstliu
approved these changes
Jun 12, 2026
jenatali
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three remaining Clang errors surfaced after the
missing onecoreuap\windows\directx\dxg\inactive\d3d9\d3d9on12\linkdll\objfre\amd64\pch.clang.pchis dropped.Validation:
Validated both MSVC and Clang build successfully.