Skip to content

fix: added dns for existing project to access #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

fix: added dns for existing project to access #610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e0d628
added dns for existing project to access
AjitPadhi-Microsoft Sep 30, 2025
5246cca
Merge remote-tracking branch 'origin/dev' into PSL-US-24142
AjitPadhi-Microsoft Oct 8, 2025
e2e47a4
updated main json file
AjitPadhi-Microsoft Oct 8, 2025
79f3d72
Merge remote-tracking branch 'origin/dev' into PSL-US-24142
AjitPadhi-Microsoft Oct 15, 2025
297b369
fixed privet endpoint issue
AjitPadhi-Microsoft Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 28 additions & 27 deletions infra/main.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,12 +460,6 @@ var dnsZoneIndex = {
sqlServer: 9
search: 10
}
// List of DNS zone indices that correspond to AI-related services.
var aiRelatedDnsZoneIndices = [
dnsZoneIndex.cognitiveServices
dnsZoneIndex.openAI
dnsZoneIndex.aiServices
]

// ===================================================
// DEPLOY PRIVATE DNS ZONES
Expand Down Expand Up @@ -736,6 +730,26 @@ resource existingAiFoundryAiServicesProject 'Microsoft.CognitiveServices/account
parent: existingAiFoundryAiServices
}

// ========== Private Endpoint for Existing AI Services ========== //
var shouldCreatePrivateEndpoint = useExistingAiFoundryAiProject && enablePrivateNetworking
var isProjectPrivate = existingAiFoundryAiServices!.properties.publicNetworkAccess == 'Enabled' ? false : true
module existingAiServicesPrivateEndpoint './modules/existing-aif-private-endpoint.bicep' = if (shouldCreatePrivateEndpoint){
name: 'create-project-private-endpoint'
params: {
isPrivate: isProjectPrivate
aiServicesName: existingAiFoundryAiServices.name
subnetResourceId: virtualNetwork!.outputs.pepsSubnetResourceId
aiServicesId: existingAiFoundryAiServices.id
location: location
cognitiveServicesDnsZoneId: avmPrivateDnsZones[dnsZoneIndex.cognitiveServices]!.outputs.resourceId
openAiDnsZoneId: avmPrivateDnsZones[dnsZoneIndex.openAI]!.outputs.resourceId
aiServicesDnsZoneId: avmPrivateDnsZones[dnsZoneIndex.aiServices]!.outputs.resourceId
tags: tags
}
dependsOn: [
avmPrivateDnsZones
]
}

//TODO: update to AVM module when AI Projects and AI Projects RBAC are supported
module aiFoundryAiServices 'modules/ai-services.bicep' = if (aiFoundryAIservicesEnabled) {
Expand Down Expand Up @@ -807,30 +821,17 @@ module aiFoundryAiServices 'modules/ai-services.bicep' = if (aiFoundryAIservices
])
: []
deployments: [
{
name: aiModelDeployments[0].name
model: {
format: aiModelDeployments[0].format
name: aiModelDeployments[0].name
version: aiModelDeployments[0].version
}
raiPolicyName: aiModelDeployments[0].raiPolicyName
sku: {
name: aiModelDeployments[0].sku.name
capacity: aiModelDeployments[0].sku.capacity
}
}
{
name: aiModelDeployments[1].name
for deployment in aiModelDeployments: {
name: deployment.name
model: {
format: aiModelDeployments[1].format
name: aiModelDeployments[1].name
version: aiModelDeployments[1].version
format: deployment.format
name: deployment.name
version: deployment.version
}
raiPolicyName: aiModelDeployments[1].raiPolicyName
raiPolicyName: deployment.raiPolicyName
sku: {
name: aiModelDeployments[1].sku.name
capacity: aiModelDeployments[1].sku.capacity
name: deployment.sku.name
capacity: deployment.sku.capacity
}
}
]
Expand Down
Loading