-
Notifications
You must be signed in to change notification settings - Fork 48
Create internal CI & PR builds #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
extends: | ||
template: azure-pipelines/MicroBuild.1ES.Unofficial.yml@MicroBuildTemplate | ||
parameters: | ||
pool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refresh my memory: the reason that we have to have two of these is because the internal builds don't have outputs that are available to the public, right?
Are there other teams that are doing this in the same way? For example, Roslyn?
I can imagine a world where these builds aren't in this repo at all, instead, we have builds that are in a separate repo that check out the source code from here. But, I don't think that those can easily be triggered from changes in github, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the internal builds don't have outputs that are available to the public, right?
That's correct, and yes, Roslyn has internal builds pulling from their public GitHub repo (eg. https://github.com/dotnet/roslyn/blob/main/azure-pipelines-pr-validation.yml)
We have builds that are in a separate repo that check out the source code from here
Moving the builds to a separate repo would help reduce churn in this repo but might make it more difficult to maintain build hygiene. Having an internal clone of the repo with builds is another option; Perfview has a process like that.
I don't think that those can easily be triggered from changes in github, right?
I think we can do something with GitHub webhooks or actions - maybe something we do in the near future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Binaries (Windows & Linux) | ||
- template: ../jobs/binaries.yaml@self | ||
parameters: | ||
IndexSources: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
This change introduces internal builds that mirror our public builds in
dev.azure.com/ms
so that we can remove a cross-org PAT token (scoped to build-artifact-read, used by our test infrastructure) that was getting flagged.Change Log
build_and_package.yaml
template that all top-level pipeline yaml can consumepr_internal.yaml
andci_internal.yaml
that rely on internal templatesTest Methodology
Internal builds