Repository navigation
Do not set role="figure" on unlabelled Adaptive Cards, and show a pointer on clickable elements - #5915
Draft
Eugene (OEvgeny) wants to merge 5 commits into
Draft
Do not set role="figure" on unlabelled Adaptive Cards, and show a pointer on clickable elements#5915Eugene (OEvgeny) wants to merge 5 commits into
Eugene (OEvgeny) wants to merge 5 commits into
Conversation
Collaborator
Author
|
TODO: show announced activities by applying styles to live region and taking snapshot |
Collaborator
Author
There was a problem hiding this comment.
quick question: why does the card text gets duplicated in the live region?
added 5 commits
October 19, 2026 19:22
A card without "speak" has no name, and an unnamed "figure" or "form" is announced without its content. Set the role only when the card has a label, fixes #5049.
Containers and images with "selectAction" get cursor: pointer; push buttons keep the default cursor, fixes #5130.
Both cards had speak 'Hello, World!', so the live region snapshot read the same line twice.
Eugene (OEvgeny)
force-pushed
the
OEvgeny/fix-ac-selectable-figure
branch
from
October 20, 2026 02:22
3a1e404 to
8ef98c4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
Adaptive Cards without
speakgot an unnamedrole="figure", and elements withselectActionhad no pointer cursor. Cards now getfigureorformonly with a label, and clickable containers and images show a pointer cursor.Design
Specific Changes
useRoleModEffect.ts: norolewhen the card has no labelAdaptiveCardRenderer.module.css:cursor: pointeron.ac-selectableexcept push buttonshack.roleMod.unlabelled.html: 2 cards withoutspeakaregeneric; snap 1: live region reads "A card:" twicehack.roleMod.html: snap 1: live region reads each card'sspeakI have added tests and executed them locally
I have updated
CHANGELOG.mdI have updated documentation
Review Checklist
z-index)package.jsonandpackage-lock.jsonreviewed