Repository navigation
Make the snapshots of recently added html2 tests easier to review - #5908
Merged
Merged
Conversation
added 3 commits
October 19, 2026 00:45
…ep and describe every snapshot - Take a snapshot after every key press in keyboard focus tests, each preceded by a THEN comment - Hide the send box where it is not under test - Replace "Should match snapshot" with what the snapshot shows - Keep test data next to the assertions that use it
…ormControls arrow key test by scenario
Eugene (OEvgeny)
marked this pull request as ready for review
October 19, 2026 18:54
Eugene (OEvgeny)
requested review from
William Wong (compulim),
Chris Whitten (cwhitten) and
TJ Durnford (tdurnford)
as code owners
October 19, 2026 18:54
Eugene (OEvgeny)
enabled auto-merge (squash)
October 19, 2026 19:07
| @@ -142,7 +150,7 @@ | |||
| expect(matchMedia('(forced-colors: active)').matches).toBe(true); | |||
Collaborator
There was a problem hiding this comment.
Nitpick: maybe we should split out another high contrast test than changing the contrast on-the-fly. For simpler test.
Collaborator
Author
There was a problem hiding this comment.
Moved forced colors into its own animationCard.gif.forcedColors.html (and .fluent) in bc2c2ae; the original test no longer switches contrast.
William Wong (compulim)
requested changes
Oct 19, 2026
added 2 commits
October 19, 2026 14:54
…y in the carousel text input test
2 of 11 tasks
Copilot started work to resolve merge conflicts on behalf of
Eugene (OEvgeny)
October 20, 2026 20:39
William Wong (compulim)
previously approved these changes
Oct 20, 2026
…weekend-tests # Conflicts: # __tests__/html2/richCard/animationCard.gif.fluent.html.snap-4.png # __tests__/html2/richCard/animationCard.gif.html Co-authored-by: OEvgeny <2841858+OEvgeny@users.noreply.github.com>
William Wong (compulim)
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Not required, development only.
Description
Some recently added keyboard tests skipped snapshots between key presses, and some snapshots did not say what they show. Keyboard tests now snapshot every key press, each snapshot follows a
// THEN:comment describing it, and the send box is hidden where it is not under test.Specific Changes
carousel/flipperButton.focusVisible,richCard/heroCard.pushButton.focusVisible,richCard/animationCard.gif: snapshot the focused element before the next key, hide the send boxrichCard/animationCard.gif.forcedColors(and.fluent): forced colors split out ofanimationCard.gifsuggestedActions/suggestedActions.flipperButton.focusVisible,transcript/navigation/visualKeyboardIndicator.styleOptions: one SHIFT-TAB per step, snapshot after eachrichCard/receiptCard.textSpacing,richCard/mediaCard.mediaList,markdown/codeBlock/remount,markdown/codeBlock/contrast,activity/programmingLanguageTitle:// THEN:describes each snapshot, samples next to their assertionscarousel/navigation.arrowKeys*: snapshot after every key, assert the settled position; splitformControlsintocards,submitButton,heroCardButton(the input case asserts the caret after every key)pageConditions.carouselSettled,testHelpers.isCardInView,testHelpers.isFlipperHidden: replace copies in the carousel testsI have added tests and executed them locally
I have updated
CHANGELOG.mdI have updated documentation
Review Checklist
z-index)package.jsonandpackage-lock.jsonreviewed