Skip to content

Commit

Permalink
Build: add entry points without top level side-effects (#5329)
Browse files Browse the repository at this point in the history
* Build: add entry points without top level side-effects

* Update d.ts tests

* Changelog

* Polish build info
  • Loading branch information
OEvgeny authored Oct 23, 2024
1 parent ae69d04 commit 7bceaaf
Show file tree
Hide file tree
Showing 40 changed files with 319 additions and 655 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ Notes: web developers are advised to use [`~` (tilde range)](https://github.com/
- Resolved [#5302](https://github.com/microsoft/BotFramework-WebChat/issues/5302). Migrated to `core-js-pure/Promise.withResolveers` from `p-defer`, in PR [#5301](https://github.com/microsoft/BotFramework-WebChat/pull/5301), by [@compulim](https://github.com/compulim)
- Improved message bubble layout in Fluent theme to allow growth beyond 450px up to 75% of container width, in PR [#5324](https://github.com/microsoft/BotFramework-WebChat/pull/5324), by [@OEvgeny](https://github.com/OEvgeny)
- Improved drop zone behavior and styling in Fluent theme, in PR [#5328](https://github.com/microsoft/BotFramework-WebChat/pull/5328), by [@OEvgeny](https://github.com/OEvgeny)
- Excluded side effects from module entry points to prevent global scope modifications, in PR [#5329](https://github.com/microsoft/BotFramework-WebChat/pull/5329), by [@OEvgeny](https://github.com/OEvgeny)

### Fixed

Expand Down
2 changes: 1 addition & 1 deletion __tests__/html/metaTag.webChat.es5.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
);

expect(buildInfo).toHaveProperty('build-tool', 'tsup');
expect(buildInfo).toHaveProperty('module-format', 'esmodules');
expect(buildInfo).toHaveProperty('module-format', 'global');
expect(buildInfo).toHaveProperty('variant', 'full-es5');
expect(buildInfo.version).toMatch(/^\d+\.\d+\.\d+($|-)/u);
});
Expand Down
2 changes: 1 addition & 1 deletion __tests__/html/metaTag.webChat.full.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
);

expect(buildInfo).toHaveProperty('build-tool', 'tsup');
expect(buildInfo).toHaveProperty('module-format', 'esmodules');
expect(buildInfo).toHaveProperty('module-format', 'global');
expect(buildInfo).toHaveProperty('variant', 'full');
expect(buildInfo.version).toMatch(/^\d+\.\d+\.\d+($|-)/u);
});
Expand Down
2 changes: 1 addition & 1 deletion __tests__/html/metaTag.webChat.minimal.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
);

expect(buildInfo).toHaveProperty('build-tool', 'tsup');
expect(buildInfo).toHaveProperty('module-format', 'esmodules');
expect(buildInfo).toHaveProperty('module-format', 'global');
expect(buildInfo).toHaveProperty('variant', 'minimal');
expect(buildInfo.version).toMatch(/^\d+\.\d+\.\d+($|-)/u);
});
Expand Down
262 changes: 3 additions & 259 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 7bceaaf

Please sign in to comment.