Skip to content

Use "Billing Period" instead of "Subscription Period" in Invoice #5523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2025
+4 −4
Merged

Use "Billing Period" instead of "Subscription Period" in Invoice #5523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Apps/W1/Subscription Billing/App/Billing/Codeunits/CreateBillingDocuments.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,7 +930,7 @@ codeunit 8060 "Create Billing Documents"

procedure GetBillingPeriodDescriptionTxt() DescriptionText: Text
begin
DescriptionText := ServicePeriodDescriptionTxt;
DescriptionText := BillingPeriodDescriptionTxt;
end;

procedure GetBillingPeriodDescriptionTxt(LanguageCode: Code[10]) DescriptionText: Text
Expand Down Expand Up @@ -1220,7 +1220,7 @@ codeunit 8060 "Create Billing Documents"
ProgressTxt: Label 'Creating documents...\Partner No. #1#################################\Contract No. #2#################################', Comment = '%1=Partner No., %2=Contract No.';
OnlyOneServicePartnerErr: Label 'You can create documents only for one type of partner at a time (Customer or Vendor). Please check your filters.';
UpdateRequiredErr: Label 'At least one Subscription Line was changed after billing proposal was created. Please check the lines marked with "Update Required" field and update the billing proposal before the billing documents can be created.';
ServicePeriodDescriptionTxt: Label 'Subscription period: %1 to %2', Comment = '%1=Recurring Billing from, %2=Recurring Billing to';
BillingPeriodDescriptionTxt: Label 'Billing period: %1 to %2', Comment = '%1=Recurring Billing from, %2=Recurring Billing to';
NoDocumentsCreatedMsg: Label 'No documents have been created.';
DocumentsCreatedMsg: Label 'Creation of documents completed.\\%1 document(s) for %2 contract(s) were created.', Comment = '%1=Number of documents, %2=Number of contracts';
DocumentsCreatedAndPostedMsg: Label 'Creation of documents completed.\\%1 document(s) for %2 contract(s) were created and posted.', Comment = '%1=Number of documents, %2=Number of contracts';
Expand Down
4 changes: 2 additions & 2 deletions src/Apps/W1/Subscription Billing/Test/Billing/RecurringBillingDocsTest.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,8 @@ codeunit 139687 "Recurring Billing Docs Test"
SalesLine2.SetRange("Attached to Line No.", SalesLine."Line No.");
Assert.AreEqual(5, SalesLine2.Count, 'Setup-failure: expected five attached Lines.');
SalesLine2.FindSet();
// 1st line: Service Period
Assert.IsSubstring(SalesLine2.Description, 'Subscription period');
// 1st line: Billing Period
Assert.IsSubstring(SalesLine2.Description, 'Billing period');
ParentSalesLine.Get(SalesLine2."Document Type", SalesLine2."Document No.", SalesLine2."Attached to Line No.");
SalesLine2.Next();
// 2nd line: Subscription Description
Expand Down
Loading