[Cryptography Management] Fix instability test #5169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groenbech96
approved these changes
Oct 15, 2025
onbuyuka
approved these changes
Oct 15, 2025
grobyns
reviewed
Oct 15, 2025
| end; | ||
|
|
||
| [TryFunction] | ||
| local procedure TryDecrypt(RSA: Codeunit RSA; XmlString: SecretText; EncryptedInStream: InStream; OaepPadding: Boolean; DecryptedOutStream: OutStream) |
Contributor
There was a problem hiding this comment.
it is better to have 2 named helpers than have a boolean parameter
grobyns
reviewed
Oct 15, 2025
| DecryptionFailed := not TryDecrypt(RSA, PrivateKeyXmlStringSecret, EncryptedInStream, true, DecryptedOutStream); | ||
|
|
||
| // [THEN] Either decryption fails with an exception, or the decrypted text is garbage (not equal to plaintext) | ||
| if not DecryptionFailed then begin |
Contributor
There was a problem hiding this comment.
there's no verification if encryption fails, no check whether the error is the expected one...
grobyns
reviewed
Oct 15, 2025
| if not DecryptionFailed then begin | ||
| DecryptingTempBlob.CreateInStream(DecryptedInStream); | ||
| DecryptedText := Base64Convert.FromBase64(Base64Convert.ToBase64(DecryptedInStream)); | ||
| LibraryAssert.AreNotEqual(PlainText, DecryptedText, 'Decryption with wrong padding should fail or return garbage data.'); |
Contributor
There was a problem hiding this comment.
your message here should only be about garbage data no? if encryption fails you will never get to this assert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When encrypting with OAEP, PKCS should not be able to decrypt it. However the padding can randomly be correct.
Updated the test to ensure we validate the output and ensure it is garbage data decrypted when it is decrypting with a different padding.
Work Item(s)
Fixes AB#609358