Repository navigation
fix(python): validate inputs in write_png helper - #9805
Open
Bartok (Bartok9) wants to merge 1 commit into
Open
Bartok (Bartok9) wants to merge 1 commit into
Bartok (Bartok9) wants to merge 1 commit into
Conversation
Reject empty filenames and non-2D/3D arrays before OpenCV, and raise OSError when imwrite fails so callers do not miss silent write errors. Signed-off-by: Bartok9 <danielrpike9@gmail.com>
Bartok (Bartok9)
force-pushed
the
aerial/python-write-png-validate-20260723
branch
from
October 25, 2026 21:27
a24a2b7 to
17d40b1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
write_pngnow validates filename/image shape before calling OpenCV and raisesOSErrorifimwritefails, so silent empty writes are not ignored.Motivation
Callers treated a failed PNG write as success when OpenCV returned false and only logged. Empty paths and bad array ranks also failed obscurely inside OpenCV.
Verification
PythonClient/airsim/tests/test_write_png.py(empty name, None image, bad ndim; write path when cv2 present).utils.write_png+ tests.AI-assisted; human-reviewed.
Claim: bartok
Operator: bartok
Campaign: aerial-drone