Add Create User-Agent Header Utility by JesuTerraz · Pull Request #98 · microsoft/Agent365-nodejs

JesuTerraz · 2025-12-03T22:13:13Z

No description provided.

Copilot

Pull request overview

This PR adds a new utility function GetUserAgentHeader that generates standardized User-Agent header strings for SDK HTTP requests. The implementation includes OS type resolution and SDK version information, with optional orchestrator identification.

Key Changes:

Added GetUserAgentHeader method to generate User-Agent strings with SDK version, OS type, Node.js version, and orchestrator info
Added private ResolveOsType helper that maps OS type names (Windows_NT→Windows, Darwin→macOS, Linux→Linux)
Comprehensive test coverage for both new methods including edge cases and OS type mapping

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
packages/agents-a365-runtime/src/utility.ts	Implements GetUserAgentHeader method and ResolveOsType helper with OS name mapping logic
tests/common/utility.test.ts	Adds comprehensive test suite for GetUserAgentHeader and ResolveOsType, plus tests for existing GetAppIdFromToken and ResolveAgentIdentity methods

Copilot

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Copilot

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Copilot

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

…b.com/microsoft/Agent365-nodejs into users/jterrazas/add-user-agent-header

Copilot

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Copilot

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Copilot

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Add User-Agent header to util class

d89e5b0

Copilot AI review requested due to automatic review settings December 3, 2025 22:13

JesuTerraz requested a review from a team as a code owner December 3, 2025 22:13

Copilot started reviewing on behalf of JesuTerraz December 3, 2025 22:13 View session

Copilot finished reviewing on behalf of JesuTerraz December 3, 2025 22:15

Copilot AI reviewed Dec 3, 2025

View reviewed changes

Comment thread packages/agents-a365-runtime/src/utility.ts Outdated

Comment thread packages/agents-a365-runtime/src/utility.ts

Comment thread packages/agents-a365-runtime/src/utility.ts Outdated

Jesus Terrazas added 2 commits December 3, 2025 15:02

Use pkginfo to get pkg version

73c58b5

update format

4bf11a6

Copilot AI review requested due to automatic review settings December 3, 2025 23:15

Copilot started reviewing on behalf of JesuTerraz December 3, 2025 23:15 View session

update test cases to work with github

6025482

Copilot finished reviewing on behalf of JesuTerraz December 3, 2025 23:22

Copilot AI reviewed Dec 3, 2025

View reviewed changes

Comment thread tests/common/utility.test.ts Outdated

Comment thread tests/common/utility.test.ts Outdated

Comment thread tests/common/utility.test.ts Outdated

Comment thread packages/agents-a365-runtime/src/utility.ts Outdated

cache version

e0764f7

rahuldevikar761 reviewed Dec 3, 2025

View reviewed changes

Comment thread packages/agents-a365-runtime/src/utility.ts Outdated

Copilot AI review requested due to automatic review settings December 4, 2025 21:48

update nodejs version format

f0c22fc

Copilot started reviewing on behalf of JesuTerraz December 4, 2025 21:48 View session

Copilot finished reviewing on behalf of JesuTerraz December 4, 2025 21:50

Copilot AI reviewed Dec 4, 2025

View reviewed changes

Comment thread tests/common/utility.test.ts Outdated

Comment thread packages/agents-a365-runtime/src/utility.ts Outdated

Comment thread packages/agents-a365-runtime/src/utility.ts Outdated

Comment thread tests/common/utility.test.ts Outdated

Jesus Terrazas and others added 2 commits December 4, 2025 14:03

copilot comments

148aea2

Merge branch 'main' into users/jterrazas/add-user-agent-header

df45069

Copilot AI review requested due to automatic review settings December 4, 2025 22:04

Copilot started reviewing on behalf of JesuTerraz December 4, 2025 22:05 View session

JesuTerraz enabled auto-merge (squash) December 4, 2025 22:07

Copilot finished reviewing on behalf of JesuTerraz December 4, 2025 22:07

Copilot AI reviewed Dec 4, 2025

View reviewed changes

Comment thread packages/agents-a365-runtime/src/utility.ts Outdated

Comment thread tests/common/utility.test.ts Outdated

Jesus Terrazas added 2 commits December 5, 2025 11:17

Remove OS parsing

7413646

Merge branch 'users/jterrazas/add-user-agent-header' of https://githu…

681c7c7

…b.com/microsoft/Agent365-nodejs into users/jterrazas/add-user-agent-header

Copilot AI review requested due to automatic review settings December 5, 2025 19:30

Merge branch 'main' into users/jterrazas/add-user-agent-header

6f05c61

Copilot started reviewing on behalf of JesuTerraz December 5, 2025 19:31 View session

Copilot AI reviewed Dec 5, 2025

View reviewed changes

read package.json instead of modifying module.exports

7b82628

Copilot AI review requested due to automatic review settings December 5, 2025 19:54

remove cached version

267ca9a

Copilot started reviewing on behalf of JesuTerraz December 5, 2025 19:55 View session

Copilot AI reviewed Dec 5, 2025

View reviewed changes

Comment thread packages/agents-a365-runtime/package.json Outdated

Comment thread packages/agents-a365-runtime/src/utility.ts Outdated

Comment thread pnpm-workspace.yaml Outdated

Comment thread pnpm-workspace.yaml Outdated

Comment thread packages/agents-a365-runtime/package.json Outdated

Jesus Terrazas and others added 2 commits December 5, 2025 12:03

Remove any pkginfo ref and use lazy init & cache version

da5c85b

Merge branch 'main' into users/jterrazas/add-user-agent-header

b6a733a

Copilot AI review requested due to automatic review settings December 5, 2025 22:14

Copilot started reviewing on behalf of pontemonti December 5, 2025 22:14 View session

pontemonti previously approved these changes Dec 5, 2025

View reviewed changes

Copilot AI reviewed Dec 5, 2025

View reviewed changes

Comment thread pnpm-lock.yaml Outdated

Comment thread packages/agents-a365-runtime/src/utility.ts Outdated

Comment thread packages/agents-a365-runtime/src/utility.ts Outdated

JesuTerraz dismissed pontemonti’s stale review via a660b9d December 9, 2025 17:38

Use prebuilt script to resolve version

a660b9d

JesuTerraz requested a review from Copilot December 9, 2025 17:39

Copilot started reviewing on behalf of JesuTerraz December 9, 2025 17:40 View session

Copilot AI reviewed Dec 9, 2025

View reviewed changes

Comment thread tests/common/utility.test.ts Outdated

Comment thread packages/agents-a365-runtime/src/utility.ts Outdated

Jesus Terrazas and others added 2 commits December 9, 2025 09:52

Remove duplicate tests

ecbf63d

Merge branch 'main' into users/jterrazas/add-user-agent-header

13efd81

Copilot AI review requested due to automatic review settings December 9, 2025 17:52

Copilot started reviewing on behalf of JesuTerraz December 9, 2025 17:52 View session

Copilot AI reviewed Dec 9, 2025

View reviewed changes

Merge branch 'main' into users/jterrazas/add-user-agent-header

3343f01

joratz approved these changes Dec 9, 2025

View reviewed changes

pontemonti approved these changes Dec 9, 2025

View reviewed changes

JesuTerraz merged commit 0bb6a32 into main Dec 9, 2025
7 checks passed

JesuTerraz deleted the users/jterrazas/add-user-agent-header branch December 9, 2025 23:43

Uh oh!

Conversation

JesuTerraz commented Dec 3, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants