Add option to use custom domain for A365 service - #92
Merged
Conversation
fpfp100
marked this pull request as ready for review
December 2, 2025 17:32
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a configurable option to route Agent365 observability exports to a custom domain, controlled by the environment variable A365_OBSERVABILITY_USE_CUSTOM_DOMAIN. When disabled, the exporter falls back to per-tenant PPAPI gateway discovery.
- Introduces useCustomDomainForObservability and resolveAgent365Endpoint helpers.
- Updates Agent365Exporter to conditionally use a custom domain and header behavior based on the flag.
- Adds tests that validate URL selection, headers, and token usage under both custom-domain and default discovery paths.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| tests/observability/core/agent365-exporter.test.ts | Adds parameterized tests for custom-domain and default discovery export paths, asserting URL and header behavior and authorization. |
| packages/agents-a365-observability/src/tracing/util.ts | Adds helpers to read the custom-domain flag and resolve the Agent365 endpoint per cluster. |
| packages/agents-a365-observability/src/tracing/exporter/Agent365Exporter.ts | Modifies export flow to use custom domain when enabled and adjusts headers; retains default discovery otherwise. |
Comments suppressed due to low confidence (1)
packages/agents-a365-observability/src/tracing/exporter/Agent365Exporter.ts:149
- Unused variable isProd.
const isProd = String(this.options.clusterCategory || '').toLowerCase() === 'prod';
juliomenendez
requested changes
Dec 2, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
Comments suppressed due to low confidence (1)
tests/observability/core/agent365-exporter.test.ts:108
- This string is not a template literal, but appears to reference the variable agentId.
{ cluster: 'prod', customDomainEnabled: false, expectedCustomDomainUrl: 'https://${endpoint}/maven/agent365/agents/${agentId}/traces?api-version=1', token: 'tok-prod-disabled' }
juliomenendez
requested changes
Dec 2, 2025
juliomenendez
approved these changes
Dec 2, 2025
threddy
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce option to use custom A365 service for SDK. Use environment variable A365_OBSERVABILITY_USE_CUSTOM_DOMAIN. When it is false, default to use PPAPI gateway endpoint per-tenant.