Update eslint - #78
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates ESLint from version 8 to version 9, migrating from the legacy .eslintrc.json configuration format to the new flat config format (eslint.config.mjs). The update also addresses ESLint errors that surfaced with the new version.
Key Changes:
- Updated ESLint and TypeScript ESLint packages from v6/v8 to v8/v9
- Created a global
eslint.config.mjsfile with flat config format - Removed individual
.eslintrc.jsonfiles from subdirectories - Fixed code to comply with new ESLint rules (prefixing unused variables with
_, adding eslint-disable comments for intentionalanytypes) - Removed
package-lock.jsonfiles in favor ofpnpm-lock.yaml - Updated GitHub workflow to use pnpm
Reviewed Changes
Copilot reviewed 38 out of 41 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
eslint.config.mjs |
New global ESLint flat config file with recommended rules |
pnpm-workspace.yaml |
Updated ESLint and TypeScript dependencies to latest versions |
pnpm-lock.yaml |
Updated lock file with new ESLint v9 dependencies |
tests/package.json, tests-agent/*/package.json |
Updated dev dependencies to ESLint v9 and TypeScript ESLint v8 |
packages/*/package.json |
Updated dev dependencies across all packages consistently |
tests/.eslintrc.json, tests-agent/*/src/.eslintrc.json, packages/*/src/.eslintrc.json |
Removed old ESLint config files |
tests-agent/basic-agent-sdk-sample/package-lock.json |
Removed npm lock file (now using pnpm) |
| TypeScript source files | Fixed ESLint violations by prefixing unused variables with _ and adding eslint-disable comments for intentional any usage |
Files not reviewed (2)
- pnpm-lock.yaml: Language not supported
- tests-agent/basic-agent-sdk-sample/package-lock.json: Language not supported
juliomenendez
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meant to address https://github.com/microsoft/Agent365-nodejs/security/dependabot/11
We were using an old version of eslint with an old config file format.
This PR updates to the latest eslint version, creates a "global" eslint config file, removes old (outdated, old format) eslint config files, and addresses some eslint errors that came up during this upgrade.
Also removed some npm
package-lock.jsonfiles that should no longer be used, and as a result had to update the github workflow to use pnpm as package manager and cache based onpnpm-lock.yamlinstead ofpackage-lock.json.