Skip to content

Exclude hostDetector from default OTel resource detectors #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fpfp100 merged 4 commits into from
May 1, 2026
Merged

Exclude hostDetector from default OTel resource detectors #244

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
73bcdd1
Exclude hostDetector from default OTel resource detectors
jsl517 Apr 30, 2026
be976de
Exclude hostDetector and serviceInstanceIdDetector from OTel resource…
jsl517 Apr 30, 2026
2d32a1a
Move resource detectors test to observabilityManager.test.ts
jsl517 Apr 30, 2026
152b11c
Update tests/observability/core/observabilityManager.test.ts
fpfp100 Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/agents-a365-observability/src/ObservabilityBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { Agent365Exporter } from './tracing/exporter/Agent365Exporter';
import type { TokenResolver } from './tracing/exporter/Agent365ExporterOptions';
import { Agent365ExporterOptions } from './tracing/exporter/Agent365ExporterOptions';
import { PerRequestSpanProcessor } from './tracing/PerRequestSpanProcessor';
import { resourceFromAttributes } from '@opentelemetry/resources';
import { resourceFromAttributes, envDetector, processDetector, serviceInstanceIdDetector } from '@opentelemetry/resources';
import { ATTR_SERVICE_NAME, ATTR_SERVICE_NAMESPACE } from '@opentelemetry/semantic-conventions';
import { trace } from '@opentelemetry/api';
import { ClusterCategory, IConfigurationProvider } from '@microsoft/agents-a365-runtime';
Expand Down Expand Up @@ -261,6 +261,7 @@ export class ObservabilityBuilder {
// Create & configure the NodeSDK manually so we can inject processors + resource.
this.sdk = new NodeSDK({
resource: this.createResource(),
resourceDetectors: [envDetector, processDetector, serviceInstanceIdDetector],
Comment thread
fpfp100 marked this conversation as resolved.
Outdated
spanProcessors: [
Comment thread
fpfp100 marked this conversation as resolved.
Comment thread
fpfp100 marked this conversation as resolved.
spanProcessor,
exportProcessor,
Expand Down
Loading