[NodeJS SDK] Allow overwriting domain and scopes on the exporter base… - #133
Merged
Conversation
…d on environment variables
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for overriding the observability domain and authentication scopes via environment variables for internal development and testing scenarios.
- Introduces
A365_OBSERVABILITY_DOMAIN_OVERRIDEenvironment variable to override the default Agent365 service endpoint - Introduces
A365_OBSERVABILITY_SCOPES_OVERRIDEenvironment variable to override the default authentication scopes - Adds comprehensive test coverage for both override mechanisms
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/agents-a365-runtime/src/environment-utils.ts |
Implements scope override logic in getObservabilityAuthenticationScope() to read from A365_OBSERVABILITY_SCOPES_OVERRIDE and split on whitespace |
packages/agents-a365-observability/src/tracing/util.ts |
Implements domain override logic in resolveAgent365Endpoint() to read from A365_OBSERVABILITY_DOMAIN_OVERRIDE with trailing slash normalization |
tests/runtime/environment-utils.test.ts |
Adds tests for scope override scenarios including single/multiple scopes, empty values, and whitespace-only inputs |
tests/observability/core/agent365-exporter.test.ts |
Adds parameterized tests for domain override scenarios and cleanup of new environment variable in teardown |
tests-agent/basic-agent-sdk-sample/.env.example |
Documents the two new environment variables with usage comments |
Nikhil Navakiran (nikhilNava)
approved these changes
Jan 7, 2026
Julio Carlos Menendez (juliomenendez)
approved these changes
Jan 7, 2026
PengF (fpfp100)
enabled auto-merge (squash)
January 7, 2026 17:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[NodeJS SDK] Allow overwriting domain and scopes on the exporter based on environment variables
This PR adds support for overriding the observability domain and authentication scopes via environment variables for internal development and testing scenarios.
Introduces A365_OBSERVABILITY_DOMAIN_OVERRIDE environment variable to override the default Agent365 service endpoint
Introduces A365_OBSERVABILITY_SCOPES_OVERRIDE environment variable to override the default authentication scopes
Adds comprehensive test coverage for both override mechanisms