Support S2S option for exporter - #123
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for Service-to-Service (S2S) endpoint routing in the Agent365 observability exporter, allowing telemetry data to be sent to a different API path when needed.
Key Changes:
- Introduced a new
useS2SEndpointboolean option inAgent365ExporterOptions - Modified endpoint path selection logic to use
/maven/agent365/service/agents/{agentId}/traceswhen S2S is enabled - Added test coverage for the S2S endpoint feature with discovery flow
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/agents-a365-observability/src/tracing/exporter/Agent365ExporterOptions.ts |
Added useS2SEndpoint property with documentation to control S2S endpoint path selection |
packages/agents-a365-observability/src/tracing/exporter/Agent365Exporter.ts |
Implemented conditional endpoint path logic based on useS2SEndpoint flag, updated class documentation, and fixed import formatting |
tests/observability/core/agent365-exporter.test.ts |
Updated existing test expectation and added new test case for S2S endpoint with discovery flow |
Julio Carlos Menendez (juliomenendez)
approved these changes
Dec 19, 2025
threddy
approved these changes
Dec 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support S2S option for exporter