Refactor existing context population code to support other scope types - #119
Merged
Conversation
PengF (fpfp100)
changed the title
PengF (fpfp100)
marked this pull request as ready for review
December 15, 2025 18:31
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the observability scope utilities to support multiple scope types (InvokeAgentScope, InferenceScope, ExecuteToolScope) through a unified ScopeUtils class, replacing the previous InvokeAgentScopeUtils that was specific to InvokeAgentScope only.
Key Changes:
- Introduced
ScopeUtilswith overloaded methods to handle different scope types - Consolidated common tag population logic across scope types
- Replaced usage of
InvokeAgentScopeUtilswithScopeUtilsthroughout the codebase
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/agents-a365-observability-hosting/src/utils/ScopeUtils.ts | New unified utility class with scope-specific population logic and method overloads |
| packages/agents-a365-observability-hosting/src/utils/InvokeAgentScopeUtils.ts | Removed the InvokeAgentScope-specific utility class |
| packages/agents-a365-observability-hosting/src/index.ts | Updated export to use ScopeUtils instead of InvokeAgentScopeUtils |
| tests-agent/basic-agent-sdk-sample/src/agent.ts | Updated import and usage from InvokeAgentScopeUtils to ScopeUtils |
| tests/observability/extension/hosting/scope-utils.test.ts | New test file for the unified ScopeUtils functionality |
| tests/observability/extension/hosting/InvokeAgentScopeUtils.test.ts | Removed old test file for InvokeAgentScopeUtils |
Julio Carlos Menendez (juliomenendez)
requested changes
Dec 15, 2025
Julio Carlos Menendez (juliomenendez)
left a comment
Julio Carlos Menendez (juliomenendez)
left a comment
There was a problem hiding this comment.
Take a look at the Copilot feedback on the tests.
Contributor
Author
The code is updated to leverage existing scope start method and expose helper methods to derive parameters used to build the scope. Tests are verifying individual attributes. |
Contributor
Author
|
Copilot open a new pull request to apply changes based on the comments in this thread |
Contributor
|
PengF (@fpfp100) I've opened a new pull request, #120, to work on those changes. Once the pull request is ready, I'll request review from you. |
Julio Carlos Menendez (juliomenendez)
requested changes
Dec 17, 2025
Julio Carlos Menendez (juliomenendez)
left a comment
Julio Carlos Menendez (juliomenendez)
left a comment
There was a problem hiding this comment.
Check the comments by Copilot.
…b.com/microsoft/Agent365-nodejs into users/pefan/contextpopulationrefactor
Julio Carlos Menendez (juliomenendez)
requested changes
Dec 17, 2025
…s.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…s.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…s.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Julio Carlos Menendez (juliomenendez)
approved these changes
Dec 17, 2025
threddy
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor existing context population code to support other scope types using overrides