Add conversation id and channel metadata to InferenceScope and ExecuteToolScope - #111
Merged
Merged
Conversation
Julio Carlos Menendez (juliomenendez)
requested changes
Dec 10, 2025
Julio Carlos Menendez (juliomenendez)
approved these changes
Dec 11, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances the observability telemetry capabilities by adding optional conversationId and sourceMetadata parameters to the InferenceScope and ExecuteToolScope classes. These additions enable better tracking of AI operations by tagging spans with conversation identifiers and channel/source information for distributed tracing.
Key Changes:
- Added optional
conversationIdparameter to bothInferenceScopeandExecuteToolScopefor tagging spans withgen_ai.conversation.id - Added optional
sourceMetadataparameter (usingPick<SourceMetadata, "name" | "description">) for tagging spans with channel name and description - Added comprehensive test coverage for both new parameters across both scope types
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
packages/agents-a365-observability/src/tracing/scopes/InferenceScope.ts |
Added conversationId and sourceMetadata parameters to start() method and constructor; tags are set via setTagMaybe() |
packages/agents-a365-observability/src/tracing/scopes/ExecuteToolScope.ts |
Added conversationId and sourceMetadata parameters to start() method and constructor; tags are set via setTagMaybe() |
tests/observability/core/scopes.test.ts |
Added tests verifying conversationId and sourceMetadata tags are correctly set for both ExecuteToolScope and InferenceScope |
threddy
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add conversation id and channel metadata to InferenceScope and ExecuteToolScope