Skip to content

Remove ENABLE_A365_OBSERVABILITY or ENABLE_OBSERVABILITY. - #110

Merged
fpfp100 merged 4 commits into
mainfrom
users/pefan/enabledefaul
Dec 10, 2025
Merged

Remove ENABLE_A365_OBSERVABILITY or ENABLE_OBSERVABILITY.#110
fpfp100 merged 4 commits into
mainfrom
users/pefan/enabledefaul

Conversation

@fpfp100

@fpfp100 fpfp100 commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

Remove ENABLE_A365_OBSERVABILITY or ENABLE_OBSERVABILITY.

Copilot AI review requested due to automatic review settings December 9, 2025 19:49
@fpfp100
fpfp100 requested review from a team as code owners December 9, 2025 19:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the observability feature from opt-in to opt-out by default. The logic in isAgent365TelemetryEnabled() now returns true unless explicitly disabled via environment variables, reversing the previous behavior where it defaulted to false.

Key Changes:

  • Modified the observability toggle logic to enable by default
  • Updated CHANGELOG to document the behavior change and release date

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/agents-a365-observability/src/tracing/util.ts Changed isAgent365TelemetryEnabled() from opt-in to opt-out logic by inverting the boolean check
CHANGELOG.md Added entry documenting the observability default change and updated release date; contains duplicate content at end of file

Comment thread CHANGELOG.md Outdated
Comment thread packages/agents-a365-observability/src/tracing/util.ts Outdated
threddy
threddy previously approved these changes Dec 9, 2025
Comment thread packages/agents-a365-observability/src/tracing/util.ts Outdated
Copilot AI review requested due to automatic review settings December 10, 2025 20:36
@fpfp100 fpfp100 changed the title Enable Observability by default Remove ENABLE_A365_OBSERVABILITY or ENABLE_OBSERVABILITY. Dec 10, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

@fpfp100
fpfp100 merged commit 0c4e2e7 into main Dec 10, 2025
7 checks passed
@fpfp100
fpfp100 deleted the users/pefan/enabledefaul branch December 10, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants