Add platformId to agent details for cross-platform observability - #103
Merged
Conversation
Co-authored-by: fpfp100 <126631706+fpfp100@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add platform ID to agent detail interfaces
Add platformId to agent details for cross-platform observability
Dec 5, 2025
Nikhil Navakiran (nikhilNava)
previously requested changes
Dec 5, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds optional platformId support to agent details and telemetry infrastructure for cross-platform observability. The changes enable tracking of platform identifiers for both agents and caller agents across the telemetry stack.
- Adds
platformIdproperty toAgentDetailsandEnhancedAgentDetailsinterfaces - Integrates
platformIdinto OpenTelemetry span attributes and baggage propagation - Provides comprehensive test coverage for the new functionality
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
packages/agents-a365-observability/src/tracing/constants.ts |
Adds two new OpenTelemetry constants for agent and caller agent platform IDs |
packages/agents-a365-observability/src/tracing/contracts.ts |
Adds optional platformId property to AgentDetails and EnhancedAgentDetails interfaces |
packages/agents-a365-observability/src/tracing/scopes/OpenTelemetryScope.ts |
Sets platform ID tag when creating spans with agent details |
packages/agents-a365-observability/src/tracing/scopes/InvokeAgentScope.ts |
Propagates caller agent platform ID in span attributes |
packages/agents-a365-observability/src/tracing/middleware/BaggageBuilder.ts |
Adds fluent API methods for setting agent and caller agent platform IDs in baggage |
packages/agents-a365-observability/src/tracing/processors/util.ts |
Includes platform ID constants in generic and invoke agent attribute arrays |
tests/observability/core/scopes.test.ts |
Adds test cases verifying platform ID creation and propagation in scopes |
tests/observability/core/BaggageBuilder.test.ts |
Adds test cases for platform ID baggage builder methods |
Julio Carlos Menendez (juliomenendez)
approved these changes
Dec 9, 2025
threddy
approved these changes
Dec 9, 2025
Julio Carlos Menendez (juliomenendez)
approved these changes
Dec 11, 2025
PengF (fpfp100)
enabled auto-merge (squash)
December 11, 2025 17:47
PengF (fpfp100)
dismissed
Nikhil Navakiran (nikhilNava)’s stale review
December 11, 2025 17:52
OOF and comment is addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional
platformIdproperty to agent details and telemetry