[.Net] Fix gen_ai.tool.arguments attribute name to gen_ai.tool.call.arguments#247
Merged
Merged
Conversation
Align with the OpenTelemetry GenAI semantic conventions by renaming the attribute from gen_ai.tool.arguments to gen_ai.tool.call.arguments. Also fixes gen_ai.tool.call_result to gen_ai.tool.call.result in tests. Mirrors microsoft/opentelemetry-distro-dotnet#88. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the observability runtime to emit OpenTelemetry GenAI tool-call attributes using the current semantic convention key (gen_ai.tool.call.arguments) and aligns tests accordingly, mirroring upstream distro behavior.
Changes:
- Renamed emitted attribute key from
gen_ai.tool.argumentstogen_ai.tool.call.argumentsviaOpenTelemetryConstants. - Fixed tool result attribute naming in tests (
gen_ai.tool.call_result→gen_ai.tool.call.result). - Updated unit and integration tests to assert against the new attribute keys and related log messages.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Tests/Microsoft.Agents.A365.Observability.Runtime.Tests/Tracing/Exporters/PayloadChunkingTests.cs | Updates representative attribute keys used in payload size estimation tests. |
| src/Tests/Microsoft.Agents.A365.Observability.Runtime.Tests/Common/ExportFormatterTests.cs | Adjusts truncation/size-logging assertions to the new tool-call arguments key. |
| src/Tests/Microsoft.Agents.A365.Observability.Runtime.IntegrationTests/Agent365ExporterE2ETests.cs | Updates E2E exporter assertions to expect gen_ai.tool.call.arguments. |
| src/Tests/Microsoft.Agents.A365.Observability.Runtime.IntegrationTests/Agent365ExporterAsyncE2ETests.cs | Updates async E2E exporter assertions to expect gen_ai.tool.call.arguments. |
| src/Observability/Runtime/Tracing/Scopes/OpenTelemetryConstants.cs | Changes the constant value for tool-call arguments to the semantic convention key. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
fpfp100
changed the title
juliomenendez
approved these changes
May 7, 2026
fpfp100
enabled auto-merge (squash)
May 8, 2026 18:04
gwharris7
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gen_ai.tool.argumentstogen_ai.tool.call.argumentsto align with OpenTelemetry GenAI semantic conventionsgen_ai.tool.call_resulttogen_ai.tool.call.resultin PayloadChunkingTestsTest plan
gen_ai.tool.call.argumentsattribute name🤖 Generated with Claude Code