Add observability instructions for coding agents#371
Merged
Conversation
- CHANGELOG: Added upgrade notes and detailed instructions for granting Observability API permissions (delegated + application) to existing agents. - a365-observability-instructions.md: New agent-oriented setup and instrumentation guide. - observability-skill-test-plan.md: New test plan for .NET project setup and code instrumentation, with agent behavior expectations. - ProjectSettingsSyncHelper: Writes EnableAgent365Exporter (boolean false) and a placeholder Agent365Observability section to .NET appsettings.json, and ENABLE_A365_OBSERVABILITY_EXPORTER=false to Python/Node.js .env. Existing values are preserved on re-run. - Logging: Clarified Observability API permission requirements and admin steps in PermissionsSubcommand and SetupHelpers. - ProjectSettingsSyncHelperTests: Added/updated tests to verify observability config for all platforms, including a new .NET section test.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds agent-focused guidance and CLI-generated configuration defaults to make Agent 365 observability setup/permissions clearer and consistent across .NET, Python, and Node.js.
Changes:
- Add default observability config outputs during setup (
EnableAgent365Exporter+Agent365Observabilityin .NET;ENABLE_A365_OBSERVABILITY_EXPORTERin.env). - Expand setup/permissions messaging with clearer Global Admin steps for delegated + application Observability API permissions.
- Add docs/test plan coverage and tests verifying new generated observability config behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Helpers/ProjectSettingsSyncHelperTests.cs | Adds assertions and a new .NET test to validate observability defaults/sections. |
| src/Microsoft.Agents.A365.DevTools.Cli/Helpers/ProjectSettingsSyncHelper.cs | Writes new observability settings into appsettings.json and .env defaults. |
| src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/SetupHelpers.cs | Improves setup summary guidance for Observability API permissions. |
| src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/PermissionsSubcommand.cs | Updates dry-run permissions output to reflect delegated + application requirement. |
| docs/agent365-guided-setup/a365-observability-instructions.md | New agent-oriented observability setup + instrumentation instructions. |
| CHANGELOG.md | Adds upgrade notes and notes new config defaults written by setup. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
ajmfehr
previously approved these changes
Apr 15, 2026
- Updated instructions to clarify exporter config should be added but disabled by default, and improved user prompt wording. - Removed setting of AgentId in ProjectSettingsSyncHelper; only AgentBlueprintId is now set. - Adjusted tests to expect AgentId to be null and verify other fields.
ajmfehr
approved these changes
Apr 16, 2026
sellakumaran
enabled auto-merge (squash)
April 16, 2026 00:04
abbinayaa
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.