Skip to content

fix: Fix crash during agent blueprint creation by improving error handling and logging in AgentBlueprintService (#366) #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sellakumaran merged 2 commits into from
Apr 16, 2026
Merged

fix: Fix crash during agent blueprint creation by improving error handling and logging in AgentBlueprintService (#366) #369

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f81d21e
fix: Improve error handling and logging in SetInheritablePermissionsA…
gs-ysingh Apr 14, 2026
def24dd
fix: address review comments on blueprint PATCH error handling (#369)
sellakumaran Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/Microsoft.Agents.A365.DevTools.Cli/Services/AgentBlueprintService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,9 +388,20 @@ public virtual async Task<bool> DeleteAgentUserAsync(
}
};

var patched = await _graphApiService.GraphPatchAsync(tenantId, patchPath, patchPayload, ct, requiredScopes);
var patched = false;
try
{
patched = await _graphApiService.GraphPatchAsync(tenantId, patchPath, patchPayload, ct, requiredScopes);
}
catch (Exception patchEx)
{
_logger.LogError(patchEx, "Exception during PATCH of inheritable permissions for blueprint {Blueprint} resource {Resource}", blueprintObjectId, resourceAppId);
return (ok: false, alreadyExists: false, error: patchEx.Message);
}

if (!patched)
{
_logger.LogWarning("PATCH request to update inheritable permissions failed for blueprint {Blueprint} resource {Resource}", blueprintObjectId, resourceAppId);
return (ok: false, alreadyExists: false, error: "PATCH failed");
Comment thread
sellakumaran marked this conversation as resolved.
Outdated
}

Expand Down Expand Up @@ -429,7 +440,7 @@ public virtual async Task<bool> DeleteAgentUserAsync(
}
catch (Exception ex)
{
_logger.LogError("Failed to set inheritable permissions: {Error}", ex.Message);
_logger.LogError(ex, "Failed to set inheritable permissions for blueprint {Blueprint} resource {Resource}: {Error}", blueprintId, resourceAppId, ex.Message);
Comment thread
sellakumaran marked this conversation as resolved.
Outdated
return (ok: false, alreadyExists: false, error: ex.Message);
}
}
Expand Down
Loading