Add OtelWrite scope, dedupe API specs, update Graph scopes - #348
Merged
Conversation
- Grant Agent365.Observability.OtelWrite to agent identities for Observability API to enable OpenTelemetry writes. - Add ChannelMessage.Read.All and ChannelMessage.Send to default delegated Graph scopes; add Files.ReadWrite.All, ChannelMessage.Read.All, and ChannelMessage.Send to application Graph scopes. - Refactor repeated ResourcePermissionSpec blocks into SetupHelpers.GetFixedApiPermissionSpecs for maintainability. - Update log messages, comments, documentation, and changelog accordingly.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Agent365 CLI setup flows to grant a new Observability permission needed for OpenTelemetry writes, expands the default Microsoft Graph scope sets for blueprints, and removes duplicated fixed API permission spec blocks by centralizing them in a shared helper.
Changes:
- Add
Agent365.Observability.OtelWritescope and include it in Observability OAuth2 grants / fixed permission specs. - Expand default Microsoft Graph delegated/application scope lists to include Teams channel messaging scopes (and
Files.ReadWrite.Allfor application scopes). - Refactor repeated fixed
ResourcePermissionSpecinitializers intoSetupHelpers.GetFixedApiPermissionSpecs(...)and reuse across setup subcommands.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.Agents.A365.DevTools.Cli/Constants/ConfigConstants.cs | Adds Observability OtelWrite scope constant; expands default Graph scope lists. |
| src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/SetupHelpers.cs | Introduces shared helper to generate the fixed platform API permission specs. |
| src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/PermissionsSubcommand.cs | Updates dry-run logging and switches to the shared fixed-spec helper for bot permissions. |
| src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/AllSubcommand.cs | Reuses the shared fixed-spec helper when building the combined permission spec list. |
| src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/AdminSubcommand.cs | Reuses the shared fixed-spec helper for GA-run permission grant completion. |
| src/Microsoft.Agents.A365.DevTools.Cli/Commands/CreateInstanceCommand.cs | Adds OtelWrite to the Observability OAuth2 permission grant scopes (in preserved deprecated code path). |
| CHANGELOG.md | Documents the new Observability scope and added Graph scopes under Unreleased. |
| .claude/agents/pr-code-reviewer.md | Adds a reviewer guideline encouraging extraction of duplicated sibling code blocks. |
sellakumaran
enabled auto-merge (squash)
April 3, 2026 18:06
ajmfehr
approved these changes
Apr 3, 2026
gwharris7
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.