Skip to content

re-enable create instance #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gwharris7 merged 17 commits into from
Apr 7, 2026
Merged

re-enable create instance #347

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0e774d6
re enable create instance + update license
Apr 2, 2026
c9f641f
update logging
Apr 2, 2026
20bd0a5
update SKUs
Apr 2, 2026
0dbf0e6
updated changelog
Apr 2, 2026
6a86671
Merge branch 'main' into users/gwharris7/create-instance
gwharris7 Apr 3, 2026
e9d1bff
PR comments
Apr 4, 2026
e4fd58e
Update CHANGELOG.md
gwharris7 Apr 4, 2026
485ab29
fix error where admin consent was still required
Apr 4, 2026
4836466
Merge branch 'users/gwharris7/create-instance' of https://github.com/…
Apr 4, 2026
8a56791
updated required API permissions
Apr 4, 2026
b1ae67b
update agent instructions
Apr 4, 2026
e1ba5dc
fixed PR comments
Apr 4, 2026
c15f928
updated changelog
Apr 4, 2026
33a5d45
typo
Apr 6, 2026
5ed3ccd
update permission checks and update app name
Apr 7, 2026
86af1d7
update instructions
Apr 7, 2026
df2f985
fixed comments
Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
## [Unreleased]

### Added
- Re-enabled `a365 create-instance` command (previously deprecated) — creates agent identity, agent user, assigns licenses, and grants admin consent for Graph/MCP/Bot Framework scopes in a single command
Comment thread
gwharris7 marked this conversation as resolved.
Outdated
- `Agent365.Observability.OtelWrite` scope now granted to all provisioned agent identities on the Observability API alongside `user_impersonation`, enabling agents to write OpenTelemetry data to the Agent 365 observability service
- `ChannelMessage.Read.All` and `ChannelMessage.Send` added to default blueprint Microsoft Graph delegated scopes (`agentIdentityScopes`)
- `Files.ReadWrite.All`, `ChannelMessage.Read.All`, and `ChannelMessage.Send` added to default blueprint Microsoft Graph application scopes (`agentApplicationScopes`)
Expand All @@ -18,6 +19,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
- `a365 publish` updates manifest IDs, creates `manifest.zip`, and prints concise upload instructions for Microsoft 365 Admin Center (Agents > All agents > Upload custom agent). Interactive prompts only occur in interactive terminals; redirect stdin to suppress them in scripts.

### Fixed
- `A365CreateInstanceRunner` sponsor handling: sponsor is now required (Graph API rejects requests without one) — removed fallback that silently stripped the sponsor on retry, which caused `BadRequest` errors
- Intermittent `ConnectionResetError (10054)` failures on corporate networks with TLS inspection proxies (Zscaler, Netskope) — Graph and ARM API calls now use direct MSAL.NET token acquisition instead of `az account get-access-token` subprocesses, bypassing the Python HTTP stack that triggered proxy resets (#321)
- `a365 cleanup` blueprint deletion now succeeds for Global Administrators even when the blueprint was created by a different user
- `a365 setup all` no longer times out for non-admin users — the CLI immediately surfaces a consent URL to share with an administrator instead of waiting for a browser prompt
Expand Down
95 changes: 21 additions & 74 deletions src/Microsoft.Agents.A365.DevTools.Cli/Commands/CreateInstanceCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ public class CreateInstanceCommand
public static Command CreateCommand(ILogger<CreateInstanceCommand> logger, IConfigService configService, CommandExecutor executor,
IBotConfigurator botConfigurator, GraphApiService graphApiService)
Comment thread
gwharris7 marked this conversation as resolved.
Outdated
{
// Command description - deprecated
// Old: Create and configure agent user identities with appropriate
// Command description
// Create and configure agent user identities with appropriate
// licenses and notification settings for your deployed agent
var command = new Command("create-instance", "DEPRECATED: Use 'a365 publish', optionally 'a365 deploy', then create instances in Microsoft Teams");
var command = new Command("create-instance", "Create and configure agent user identities with appropriate licenses and notification settings for your deployed agent");
Comment thread
gwharris7 marked this conversation as resolved.

// Options for the main create-instance command
var configOption = new Option<FileInfo>(
Expand All @@ -44,18 +44,13 @@ public static Command CreateCommand(ILogger<CreateInstanceCommand> logger, IConf
command.AddOption(verboseOption);
command.AddOption(dryRunOption);

// Subcommands removed - command is deprecated
// Keeping subcommand implementation code for local development only
// Subcommands
command.AddCommand(CreateIdentitySubcommand(logger, configService, executor, graphApiService));
command.AddCommand(CreateLicensesSubcommand(logger, configService, executor, graphApiService));

// Default handler
command.SetHandler(async (config, verbose, dryRun) =>
{
LogDeprecationError(logger, "create-instance");
Environment.Exit(1);

// Unreachable code below - preserved for local development use cases
#pragma warning disable CS0162 // Unreachable code detected

if (dryRun)
{
logger.LogInformation("DRY RUN: Agent 365 Instance Creation - All Steps");
Comment thread
gwharris7 marked this conversation as resolved.
Expand All @@ -82,19 +77,13 @@ public static Command CreateCommand(ILogger<CreateInstanceCommand> logger, IConf
logger.LogInformation("Step 1-3: Creating Agent Identity, adding licenses, and registering MCP servers...");
logger.LogInformation("");

// Use C# runner with AuthenticationService and GraphApiService
var cleanLoggerFactory = LoggerFactoryHelper.CreateCleanLoggerFactory();
var authService = new AuthenticationService(
cleanLoggerFactory.CreateLogger<AuthenticationService>());

var graphService = new GraphApiService(
cleanLoggerFactory.CreateLogger<GraphApiService>(),
executor);
// Use C# runner with the DI-injected GraphApiService (has MSAL auth context)
using var cleanLoggerFactory = LoggerFactoryHelper.CreateCleanLoggerFactory();

var instanceRunner = new A365CreateInstanceRunner(
cleanLoggerFactory.CreateLogger<A365CreateInstanceRunner>(),
executor,
graphService);
graphApiService);

var generatedConfigPath = Path.Combine(
config.DirectoryName ?? Environment.CurrentDirectory,
Expand Down Expand Up @@ -254,7 +243,7 @@ public static Command CreateCommand(ILogger<CreateInstanceCommand> logger, IConf
generatedConfigPath = Path.Combine(
config.DirectoryName ?? Environment.CurrentDirectory,
"a365.generated.config.json");
var syncLoggerFactory = LoggerFactoryHelper.CreateCleanLoggerFactory();
using var syncLoggerFactory = LoggerFactoryHelper.CreateCleanLoggerFactory();
var platformDetector = new PlatformDetector(syncLoggerFactory.CreateLogger<PlatformDetector>());

await ProjectSettingsSyncHelper.ExecuteAsync(
Expand Down Expand Up @@ -288,7 +277,8 @@ await ProjectSettingsSyncHelper.ExecuteAsync(
private static Command CreateIdentitySubcommand(
ILogger<CreateInstanceCommand> logger,
IConfigService configService,
CommandExecutor executor)
CommandExecutor executor,
GraphApiService graphApiService)
{
var command = new Command("identity", "Create Agent Identity and Agent User");

Expand All @@ -311,12 +301,6 @@ private static Command CreateIdentitySubcommand(

command.SetHandler(async (config, verbose, dryRun) =>
{
LogDeprecationError(logger, "create-instance identity");
Environment.Exit(1);

// Unreachable code below - preserved for local development
#pragma warning disable CS0162

if (dryRun)
{
logger.LogInformation("DRY RUN: Creating Agent Identity and Agent User");
Comment thread
gwharris7 marked this conversation as resolved.
Expand All @@ -333,19 +317,13 @@ private static Command CreateIdentitySubcommand(
var instanceConfig = await LoadConfigAsync(logger, configService, config.FullName);
if (instanceConfig == null) Environment.Exit(1);

// Use C# runner with AuthenticationService and GraphApiService
var cleanLoggerFactory = LoggerFactoryHelper.CreateCleanLoggerFactory();
var authService = new AuthenticationService(
cleanLoggerFactory.CreateLogger<AuthenticationService>());

var graphService = new GraphApiService(
cleanLoggerFactory.CreateLogger<GraphApiService>(),
executor);
// Use C# runner with the DI-injected GraphApiService (has MSAL auth context)
using var cleanLoggerFactory = LoggerFactoryHelper.CreateCleanLoggerFactory();

var instanceRunner = new A365CreateInstanceRunner(
cleanLoggerFactory.CreateLogger<A365CreateInstanceRunner>(),
executor,
graphService);
graphApiService);

var generatedConfigPath = Path.Combine(
config.DirectoryName ?? Environment.CurrentDirectory,
Expand All @@ -368,7 +346,7 @@ private static Command CreateIdentitySubcommand(
config.DirectoryName ?? Environment.CurrentDirectory,
"a365.generated.config.json");

var syncLoggerFactory = LoggerFactoryHelper.CreateCleanLoggerFactory();
using var syncLoggerFactory = LoggerFactoryHelper.CreateCleanLoggerFactory();
var platformDetector = new PlatformDetector(syncLoggerFactory.CreateLogger<PlatformDetector>());

await ProjectSettingsSyncHelper.ExecuteAsync(
Expand Down Expand Up @@ -402,7 +380,8 @@ await ProjectSettingsSyncHelper.ExecuteAsync(
private static Command CreateLicensesSubcommand(
ILogger<CreateInstanceCommand> logger,
IConfigService configService,
CommandExecutor executor)
CommandExecutor executor,
GraphApiService graphApiService)
{
var command = new Command("licenses", "Add licenses to Agent User");

Expand All @@ -425,12 +404,6 @@ private static Command CreateLicensesSubcommand(

command.SetHandler(async (config, verbose, dryRun) =>
{
LogDeprecationError(logger, "create-instance licenses");
Environment.Exit(1);

// Unreachable code below - preserved for local development
#pragma warning disable CS0162

if (dryRun)
{
logger.LogInformation("DRY RUN: Adding licenses to Agent User");
Expand All @@ -446,19 +419,13 @@ private static Command CreateLicensesSubcommand(
var instanceConfig = await LoadConfigAsync(logger, configService, config.FullName);
if (instanceConfig == null) Environment.Exit(1);

// Use C# runner with AuthenticationService and GraphApiService
var cleanLoggerFactory = LoggerFactoryHelper.CreateCleanLoggerFactory();
var authService = new AuthenticationService(
cleanLoggerFactory.CreateLogger<AuthenticationService>());

var graphService = new GraphApiService(
cleanLoggerFactory.CreateLogger<GraphApiService>(),
executor);
// Use C# runner with the DI-injected GraphApiService (has MSAL auth context)
using var cleanLoggerFactory = LoggerFactoryHelper.CreateCleanLoggerFactory();

var instanceRunner = new A365CreateInstanceRunner(
cleanLoggerFactory.CreateLogger<A365CreateInstanceRunner>(),
executor,
graphService);
graphApiService);

var generatedConfigPath = Path.Combine(
config.DirectoryName ?? Environment.CurrentDirectory,
Expand Down Expand Up @@ -512,24 +479,4 @@ private static Command CreateLicensesSubcommand(
}
}

/// <summary>
/// Logs deprecation error message for create-instance command and its subcommands.
/// Uses plain ASCII text for cross-platform compatibility.
/// </summary>
private static void LogDeprecationError(ILogger logger, string commandName)
{
logger.LogError("ERROR: Command '{Command}' has been deprecated.", commandName);
logger.LogError("");
logger.LogError("This command bypasses the standard agent registration workflow,");
logger.LogError("which prevents proper agent registration and event propagation.");
logger.LogError("");
logger.LogError("Use the recommended workflow instead:");
logger.LogError(" 1. Run 'a365 publish' to package and upload your agent manifest");
logger.LogError(" 2. Run 'a365 deploy' to deploy your application (if Azure-hosted)");
logger.LogError(" 3. Create an agent instance through Microsoft Teams");
logger.LogError("");
logger.LogError("For more information, see:");
logger.LogError("https://learn.microsoft.com/microsoft-agent-365/onboard");
logger.LogError("");
}
}
Loading
Loading