feat: MCP V1-to-V2 discovery migration

[biswapm]

Summary

• McpServerConfig: add id and publisher fields for V2 schema (V1 entries get null — no breaking change)
• McpConstants: add V2ScopeValue, IsV1Scope() helper, ManifestProperties.Id/Publisher
• McpServerCatalogWriter: normalize V2 bare-array responses to wrapped format
• DevelopCommand: call live discoverToolServers V2 endpoint directly; log error and exit on failure
• ManifestHelper: add GetScopesByAudienceAsync() — groups manifest entries by audience
  (resourceAppId), supporting V1 (shared ATG AppId), V2 (per-server GUIDs), and mixed
  manifests. Fallback: missing or api:// audience resolves to ATG AppId.
• PermissionsSubcommand: replace single-spec ATG write with per-audience ResourcePermissionSpec
  list so V2 per-server AppIds are written correctly alongside ATG scopes (additive by default).
• PermissionsSubcommand: add --remove-legacy-scopes flag to setup permissions mcp with
  confirmation prompt — excludes ATG audience from blueprint write after V2 SDK is live.

Notes

V1 path unchanged. ATG scopes preserved by default.

Test plan

• 9 new McpServerCatalogWriterTests (normalization, IsV1Scope)
• 3 new McpServerConfigTests (V2 fields, deserialization, V1/V2 coexistence)
• Full suite: 1280 passed / 0 failed

[github-actions]

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[Copilot]

Pull request overview

This PR advances the MCP discovery migration by supporting V2 catalog schema fields, normalizing V2 “bare array” responses into the existing wrapped catalog format, and introducing a temporary hardcoded V2 catalog fallback to unblock development while the live V2 endpoint is pending.

Changes:

• Added V2 schema support (id, publisher) to McpServerConfig plus related constants/helpers (V2ScopeValue, IsV1Scope, manifest property names).
• Updated catalog writing to normalize V2 raw-array responses and added a hardcoded V2 catalog writer.
• Updated DevelopCommand to fall back to the hardcoded catalog when the endpoint call fails; added/expanded unit tests for normalization and V2 fields.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Services/Internal/McpServerCatalogWriterTests.cs	Adds tests for V2 normalization, hardcoded catalog writing, and new constants/helpers.
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Models/McpServerConfigTests.cs	Adds tests asserting V2 fields default/null behavior and V1/V2 deserialization behavior.
src/Microsoft.Agents.A365.DevTools.Cli/Services/Internal/McpServerCatalogWriter.cs	Normalizes V2 raw-array catalogs into wrapped format; adds hardcoded V2 catalog writer.
src/Microsoft.Agents.A365.DevTools.Cli/Models/McpServerConfig.cs	Extends server config model with V2 id and publisher properties.
src/Microsoft.Agents.A365.DevTools.Cli/Constants/McpConstants.cs	Adds V2 scope constant, IsV1Scope helper, manifest property names, and hardcoded V2 catalog JSON.
src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopCommand.cs	Adds fallback behavior to write hardcoded V2 catalog when discover endpoint fails; adds second guard for add-mcp-servers.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 7 comments.

Comments suppressed due to low confidence (1)

scripts/cli/Auth/New-Agent365ToolsServicePrincipalProdPublic.ps1:145

• The script output includes non-ASCII symbols (e.g., "⚠", "✓", "✗"). Repo guidance is to avoid emojis/special characters in output for cross-platform terminal compatibility/log parsing. Replace these with plain text equivalents like "WARNING:", "Connected", "ERROR".

Write-Host "Connecting to Microsoft Graph..." -ForegroundColor Cyan
Write-Host "⚠ You need admin permissions for this operation." -ForegroundColor Yellow
Write-Host ""

try {
    Connect-MgGraph -Scopes "AppRoleAssignment.ReadWrite.All" -NoWelcome
    $context = Get-MgContext
    Write-Host "✓ Connected to tenant: $($context.TenantId)" -ForegroundColor Green
    Write-Host ""
}
catch {
    Write-Host "✗ Failed to connect to Microsoft Graph" -ForegroundColor Red
    Write-Host $_.Exception.Message -ForegroundColor Red

[Copilot]

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 7 comments.

Comments suppressed due to low confidence (1)

src/Microsoft.Agents.A365.DevTools.Cli/Constants/ConfigConstants.cs:1

• GetDiscoverEndpointUrl now always returns ProductionDiscoverEndpointUrl regardless of environment, but still uses a switch expression. This adds complexity without behavior. Consider returning the constant directly (or reintroducing environment-specific endpoints if intended). Also, ensure indentation on the constant definition stays consistent with the surrounding file formatting to avoid style/lint churn.

// Copyright (c) Microsoft Corporation.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

scripts/cli/Auth/New-Agent365ToolsServicePrincipalProdPublic.ps1:145

• The script outputs non-ASCII symbols (e.g., "⚠", "✓", "✗"). Repository guidance for CLI-facing output is plain text without emojis/special characters to ensure cross-terminal compatibility and easy log parsing. Please replace these with ASCII equivalents like "WARNING:", "OK", "ERROR".

Write-Host "Connecting to Microsoft Graph..." -ForegroundColor Cyan
Write-Host "⚠ You need admin permissions for this operation." -ForegroundColor Yellow
Write-Host ""

try {
    Connect-MgGraph -Scopes "AppRoleAssignment.ReadWrite.All" -NoWelcome
    $context = Get-MgContext
    Write-Host "✓ Connected to tenant: $($context.TenantId)" -ForegroundColor Green
    Write-Host ""
}
catch {
    Write-Host "✗ Failed to connect to Microsoft Graph" -ForegroundColor Red
    Write-Host $_.Exception.Message -ForegroundColor Red

[Copilot]

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (2)

src/Microsoft.Agents.A365.DevTools.Cli/Helpers/ManifestHelper.cs:89

• V2 schema introduces an id field, and McpConstants.ManifestProperties.Id exists, but CreateCompleteServerObject/ConvertToServerObjects never read or write id. As a result, any manifest round-trip (read → write) or add-mcp-servers update will drop id values. If id is meant to be persisted for V2 entries, add an optional id parameter and include it in the dictionary when present, and plumb it through the callers that build server objects from catalog/manifest JSON.

    public static object CreateCompleteServerObject(string serverName, string? uniqueName = null, string? url = null, string? scope = null, string? audience = null, string? publisher = null)
    {
        var serverObj = new Dictionary<string, object>
        {
            [McpConstants.ManifestProperties.McpServerName] = serverName,
            [McpConstants.ManifestProperties.McpServerUniqueName] = uniqueName ?? serverName
        };

scripts/cli/Auth/New-Agent365ToolsServicePrincipalProdPublic.ps1:145

• This script writes non-ASCII symbols (e.g., "⚠", "✓", "✗", and em-dash "—") to the console. These characters can render poorly or break copy/paste in some terminals and encodings (especially on Windows PowerShell with older code pages). Prefer plain ASCII equivalents (e.g., "WARNING:", "OK:", "ERROR:", and "-") for consistent cross-platform output.

Write-Host "Connecting to Microsoft Graph..." -ForegroundColor Cyan
Write-Host "⚠ You need admin permissions for this operation." -ForegroundColor Yellow
Write-Host ""

try {
    Connect-MgGraph -Scopes "AppRoleAssignment.ReadWrite.All" -NoWelcome
    $context = Get-MgContext
    Write-Host "✓ Connected to tenant: $($context.TenantId)" -ForegroundColor Green
    Write-Host ""
}
catch {
    Write-Host "✗ Failed to connect to Microsoft Graph" -ForegroundColor Red
    Write-Host $_.Exception.Message -ForegroundColor Red