Fix publish/setup docs and Node Oryx TypeScript deploy behavior#318
Closed
ITSpecialist111 wants to merge 5 commits into
Closed
Fix publish/setup docs and Node Oryx TypeScript deploy behavior#318ITSpecialist111 wants to merge 5 commits into
ITSpecialist111 wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Agent365 CLI and docs to reduce friction when publishing/deploying Node.js/TypeScript agents, with a focus on avoiding common Oryx remote-build failures and clarifying the intended publish workflow.
Changes:
- Adjust Node Oryx manifest generation to skip remote build actions when
dist/is already present in the publish output. - Update guided setup and publish instructions to reflect the current manual-upload workflow and preview discovery behavior.
- Refine App Service Plan SKU guidance to steer users away from F1 for Node.js/TypeScript remote builds.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Microsoft.Agents.A365.DevTools.Cli/Services/NodeBuilder.cs | Detects dist/ in publish output and changes Oryx manifest build behavior/logging accordingly. |
| src/Microsoft.Agents.A365.DevTools.Cli/Services/ConfigurationWizardService.cs | Updates SKU guidance messaging shown in the interactive configuration wizard. |
| src/Microsoft.Agents.A365.DevTools.Cli/Exceptions/NodeBuildFailedException.cs | Expands mitigation steps for Node build failures (notably TypeScript-related guidance). |
| docs/agent365-guided-setup/a365-setup-instructions.md | Clarifies publish workflow (manual upload), adds admin-consent warning, and updates agent discovery guidance during preview. |
- Fix indentation inconsistencies in NodeBuilder.cs, ConfigurationWizardService.cs, and NodeBuildFailedException.cs - Narrow Oryx skip heuristic: require both dist/ and tsconfig.json to avoid silently skipping remote builds for JavaScript-only projects that use dist/ for webpack output - Add NodeBuilderTests covering: TypeScript+dist (skip), TypeScript without dist (build), JavaScript+dist (build), no build script (no build) - Remove emoji from documentation warning block (cross-platform terminal compatibility) - Add CHANGELOG.md entries for Oryx skip behavior and SKU recommendation change Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- NodeBuilder: fix log message to use ASCII-only and clarify that only the npm run build step is skipped in the Oryx manifest, not the entire Oryx process - NodeBuildFailedException: reword tsc-not-found mitigation to local build context; remove misleading reference to Azure App Service Oryx (this exception is thrown during local builds where Oryx does not apply) - Docs: reconcile admin consent guidance — remediation steps now direct users to apply grants via Graph API only, consistent with the warning above Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sellakumaran
previously approved these changes
Mar 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Agent365 CLI documentation and improves Node.js/TypeScript deployment reliability by adjusting how the Oryx manifest is generated for TypeScript projects with prebuilt dist/ output.
Changes:
- Skip Oryx remote build in the Node Oryx manifest when a TypeScript project already has
dist/in the publish output. - Add unit tests covering the new NodeBuilder manifest behavior for TS/JS projects.
- Update setup/publish documentation, wizard SKU guidance, error mitigations, and changelog entries.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/Microsoft.Agents.A365.DevTools.Cli/Services/NodeBuilder.cs |
Adds TS+dist/ detection to omit Oryx build section and avoid tsc failures. |
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Services/NodeBuilderTests.cs |
New tests validating manifest build-skip vs build-required scenarios. |
src/Microsoft.Agents.A365.DevTools.Cli/Services/ConfigurationWizardService.cs |
Updates console guidance to recommend B1 and warn against F1 for Node/TS remote builds. |
src/Microsoft.Agents.A365.DevTools.Cli/Exceptions/NodeBuildFailedException.cs |
Adds additional mitigation guidance for tsc: not found. |
docs/agent365-guided-setup/a365-setup-instructions.md |
Clarifies publish workflow and adds consent/discovery guidance. |
CHANGELOG.md |
Adds entries documenting the SKU guidance and Node/TS deploy fix. |
gwharris7
requested changes
Mar 27, 2026
- Remove outdated WARNING about AgentIdentityBlueprint grants being invisible in Entra admin center and silently deleted on consent - Correct API endpoint reference from appRoleAssignments (application permissions) to oauth2PermissionGrants (delegated permissions) - Update Frontier preview note to reflect that both M365 Copilot > Apps and Teams > Apps can surface the agent depending on tenant rollout Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sellakumaran
enabled auto-merge (squash)
March 30, 2026 15:31
gwharris7
approved these changes
Mar 31, 2026
Contributor
|
Deploy command has been removed before GA. Closing this PR. |
auto-merge was automatically disabled
April 24, 2026 17:48
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix publish/setup docs and Node Oryx TypeScript deploy behavior
Summary of changes:
Clarified publish workflow and setup instructions in documentation.
Added warnings and guidance for Entra admin consent and Copilot/Teams agent discovery.
Updated SKU recommendation logic to prefer B1 and warn against F1 for Node.js/TypeScript agents.
Improved Node.js/TypeScript deployment: Oryx now skips remote build if dist/ exists, preventing tsc-not-found errors.
Enhanced error messages with mitigation steps for TypeScript build issues.
Why these changes?
These updates address common setup and deployment issues, improve onboarding clarity, and reduce friction for new users deploying Node.js/TypeScript agents.