Skip to content

Upgrade agent framework and semantic kernel .NET versions and remove E2E workflows #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gwharris7 merged 9 commits into from
May 6, 2026
Merged

Upgrade agent framework and semantic kernel .NET versions and remove E2E workflows #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f677b8e
Upgrade Agent Framework sample to Agent365 GA (1.0.0) with observabil…
sellakumaran May 1, 2026
9a182f7
Remove Agent365 observability and improve tool argument handling
sellakumaran May 4, 2026
6d2a76c
Refactor AgentDetails construction into helper class
sellakumaran May 4, 2026
5fbbc37
Migrate .NET agent-framework sample to Microsoft.OpenTelemetry distro
sellakumaran May 5, 2026
424a390
fix(dotnet/agent-framework): address Copilot PR review comments in My…
sellakumaran May 5, 2026
fdc3d34
fix(dotnet/agent-framework): use discard in WelcomeMessageAsync foreach
sellakumaran May 5, 2026
41797e8
remove e2e tests temporarily and update package versions
May 6, 2026
20cd5b1
fix copyright header
gwharris7 May 6, 2026
1f356ec
Fix system prompt to reference correct tool name DateTimeFunctionTool…
Copilot May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 0 additions & 110 deletions .github/workflows/e2e-dotnet-agent-framework.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,114 +56,4 @@ jobs:
-Runtime "dotnet" `
-WorkingDirectory "${{ env.SAMPLE_PATH }}"

- name: Acquire Bearer Token (ROPC)
id: token
shell: pwsh
run: |
$token = & "${{ env.SCRIPTS_PATH }}/Acquire-BearerToken.ps1" `
-ClientId "${{ secrets.MCP_CLIENT_ID }}" `
-TenantId "${{ secrets.MCP_TENANT_ID }}" `
-Username "${{ secrets.MCP_TEST_USERNAME }}" `
-Password "${{ secrets.MCP_TEST_PASSWORD }}"
echo "BEARER_TOKEN=$token" >> $env:GITHUB_OUTPUT
echo "::add-mask::$token"

- name: Copy ToolingManifest.json
shell: pwsh
run: |
& "${{ env.SCRIPTS_PATH }}/Copy-ToolingManifest.ps1" -TargetPath "${{ env.SAMPLE_PATH }}"

- name: Generate appsettings.json
shell: pwsh
run: |
$configMappings = @{
"AIServices:AzureOpenAI:Endpoint" = "${{ secrets.DOTNET_AF_AZURE_OPENAI_ENDPOINT }}"
"AIServices:AzureOpenAI:ApiKey" = "${{ secrets.DOTNET_AF_AZURE_OPENAI_API_KEY }}"
"AIServices:AzureOpenAI:DeploymentName" = "${{ secrets.DOTNET_AF_AZURE_OPENAI_DEPLOYMENT }}"
"TokenValidation:Enabled" = "false"
"Connections:ServiceConnection:Settings:AuthType" = "ClientSecret"
"Connections:ServiceConnection:Settings:ClientId" = "${{ secrets.DOTNET_AF_CLIENT_ID }}"
"Connections:ServiceConnection:Settings:ClientSecret" = "${{ secrets.DOTNET_AF_CLIENT_SECRET }}"
"Connections:ServiceConnection:Settings:TenantId" = "${{ secrets.TENANT_ID }}"
"Connections:ServiceConnection:Settings:AuthorityEndpoint" = "https://login.microsoftonline.com/${{ secrets.TENANT_ID }}"
"Connections:ServiceConnection:Settings:Scopes:0" = "5a807f24-c9de-44ee-a3a7-329e88a00ffc/.default"
}
& "${{ env.SCRIPTS_PATH }}/Generate-AppSettings.ps1" `
-OutputPath "${{ env.SAMPLE_PATH }}/appsettings.json" `
-ConfigMappings $configMappings

- name: Start Agent
id: start-agent
shell: pwsh
run: |
$agentPid = & "${{ env.SCRIPTS_PATH }}/Start-Agent.ps1" `
-AgentPath "${{ env.SAMPLE_PATH }}" `
-StartCommand "dotnet run --no-build" `
-Port ${{ env.AGENT_PORT }} `
-BearerToken "${{ steps.token.outputs.BEARER_TOKEN }}" `
-Environment "Development" `
-Runtime "dotnet"
echo "AGENT_PID=$agentPid" >> $env:GITHUB_OUTPUT

- name: Verify Agent Running
shell: pwsh
run: |
$agentPid = "${{ steps.start-agent.outputs.AGENT_PID }}"
if ($agentPid) {
try {
$proc = Get-Process -Id $agentPid -ErrorAction Stop
Write-Host "Agent process (PID: $agentPid) is running: $($proc.ProcessName)" -ForegroundColor Green
} catch {
Write-Host "ERROR: Agent process (PID: $agentPid) is NOT running!" -ForegroundColor Red
throw "Agent process has stopped"
}
}
$response = Invoke-WebRequest -Uri "http://localhost:${{ env.AGENT_PORT }}/api/health" -UseBasicParsing -ErrorAction SilentlyContinue
Write-Host "Health: $($response.StatusCode)" -ForegroundColor Green

- name: Restore E2E Test Dependencies
run: dotnet restore "${{ env.E2E_TESTS_PATH }}/Agent365.E2E.Tests.csproj"

- name: Run .NET E2E Tests
shell: pwsh
run: |
dotnet test "${{ env.E2E_TESTS_PATH }}/Agent365.E2E.Tests.csproj" `
--no-restore `
--verbosity normal `
--logger "console;verbosity=detailed" `
--logger "trx;LogFileName=test-results-dotnet-af.trx"
env:
TEST_RESULTS_DIR: ${{ runner.temp }}/TestConversations

- name: Emit Test Conversations
if: always()
shell: pwsh
run: |
& "${{ env.SCRIPTS_PATH }}/Emit-TestConversations.ps1" `
-TestResultsDir "${{ runner.temp }}/TestConversations"

- name: Capture Agent Logs
if: always()
shell: pwsh
run: |
& "${{ env.SCRIPTS_PATH }}/Capture-AgentLogs.ps1" `
-AgentPath "${{ env.SAMPLE_PATH }}"

- name: Stop Agent Process
if: always()
shell: pwsh
run: |
$agentPid = "${{ steps.start-agent.outputs.AGENT_PID }}"
if ($agentPid) {
& "${{ env.SCRIPTS_PATH }}/Stop-AgentProcess.ps1" -AgentPID $agentPid
}

- name: Upload Test Results
if: always()
uses: actions/upload-artifact@v4
with:
name: test-results-dotnet-af
path: |
${{ env.E2E_TESTS_PATH }}/TestResults/**/*.trx
${{ env.E2E_TESTS_PATH }}/TestResults/**/*-logs.txt
retention-days: 7
110 changes: 0 additions & 110 deletions .github/workflows/e2e-dotnet-semantic-kernel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,114 +56,4 @@ jobs:
-Runtime "dotnet" `
-WorkingDirectory "${{ env.SAMPLE_PATH }}"

- name: Acquire Bearer Token (ROPC)
id: token
shell: pwsh
run: |
$token = & "${{ env.SCRIPTS_PATH }}/Acquire-BearerToken.ps1" `
-ClientId "${{ secrets.MCP_CLIENT_ID }}" `
-TenantId "${{ secrets.MCP_TENANT_ID }}" `
-Username "${{ secrets.MCP_TEST_USERNAME }}" `
-Password "${{ secrets.MCP_TEST_PASSWORD }}"
echo "BEARER_TOKEN=$token" >> $env:GITHUB_OUTPUT
echo "::add-mask::$token"

- name: Copy ToolingManifest.json
shell: pwsh
run: |
& "${{ env.SCRIPTS_PATH }}/Copy-ToolingManifest.ps1" -TargetPath "${{ env.SAMPLE_PATH }}"

- name: Generate appsettings.json
shell: pwsh
run: |
$configMappings = @{
"AIServices:UseAzureOpenAI" = "true"
"AIServices:AzureOpenAI:Endpoint" = "${{ secrets.DOTNET_SK_AZURE_OPENAI_ENDPOINT }}"
"AIServices:AzureOpenAI:ApiKey" = "${{ secrets.DOTNET_SK_AZURE_OPENAI_API_KEY }}"
"AIServices:AzureOpenAI:DeploymentName" = "${{ secrets.DOTNET_SK_AZURE_OPENAI_DEPLOYMENT }}"
"TokenValidation:Enabled" = "false"
"TokenValidation:TenantId" = "${{ secrets.TENANT_ID }}"
"Connections:ServiceConnection:Settings:AuthType" = "ClientSecret"
"Connections:ServiceConnection:Settings:ClientId" = "${{ secrets.DOTNET_SK_CLIENT_ID }}"
"Connections:ServiceConnection:Settings:ClientSecret" = "${{ secrets.DOTNET_SK_CLIENT_SECRET }}"
"Connections:ServiceConnection:Settings:TenantId" = "${{ secrets.TENANT_ID }}"
}
& "${{ env.SCRIPTS_PATH }}/Generate-AppSettings.ps1" `
-OutputPath "${{ env.SAMPLE_PATH }}/appsettings.json" `
-ConfigMappings $configMappings

- name: Start Agent
id: start-agent
shell: pwsh
run: |
$agentPid = & "${{ env.SCRIPTS_PATH }}/Start-Agent.ps1" `
-AgentPath "${{ env.SAMPLE_PATH }}" `
-StartCommand "dotnet run --no-build" `
-Port ${{ env.AGENT_PORT }} `
-BearerToken "${{ steps.token.outputs.BEARER_TOKEN }}" `
-Environment "Development" `
-Runtime "dotnet"
echo "AGENT_PID=$agentPid" >> $env:GITHUB_OUTPUT

- name: Verify Agent Running
shell: pwsh
run: |
$agentPid = "${{ steps.start-agent.outputs.AGENT_PID }}"
if ($agentPid) {
try {
$proc = Get-Process -Id $agentPid -ErrorAction Stop
Write-Host "Agent process (PID: $agentPid) is running: $($proc.ProcessName)" -ForegroundColor Green
} catch {
Write-Host "ERROR: Agent process (PID: $agentPid) is NOT running!" -ForegroundColor Red
throw "Agent process has stopped"
}
}
$response = Invoke-WebRequest -Uri "http://localhost:${{ env.AGENT_PORT }}/api/health" -UseBasicParsing -ErrorAction SilentlyContinue
Write-Host "Health: $($response.StatusCode)" -ForegroundColor Green

- name: Restore E2E Test Dependencies
run: dotnet restore "${{ env.E2E_TESTS_PATH }}/Agent365.E2E.Tests.csproj"

- name: Run .NET E2E Tests
shell: pwsh
run: |
dotnet test "${{ env.E2E_TESTS_PATH }}/Agent365.E2E.Tests.csproj" `
--no-restore `
--verbosity normal `
--logger "console;verbosity=detailed" `
--logger "trx;LogFileName=test-results-dotnet-sk.trx"
env:
TEST_RESULTS_DIR: ${{ runner.temp }}/TestConversations

- name: Emit Test Conversations
if: always()
shell: pwsh
run: |
& "${{ env.SCRIPTS_PATH }}/Emit-TestConversations.ps1" `
-TestResultsDir "${{ runner.temp }}/TestConversations"

- name: Capture Agent Logs
if: always()
shell: pwsh
run: |
& "${{ env.SCRIPTS_PATH }}/Capture-AgentLogs.ps1" `
-AgentPath "${{ env.SAMPLE_PATH }}"

- name: Stop Agent Process
if: always()
shell: pwsh
run: |
$agentPid = "${{ steps.start-agent.outputs.AGENT_PID }}"
if ($agentPid) {
& "${{ env.SCRIPTS_PATH }}/Stop-AgentProcess.ps1" -AgentPID $agentPid
}

- name: Upload Test Results
if: always()
uses: actions/upload-artifact@v4
with:
name: test-results-dotnet-sk
path: |
${{ env.E2E_TESTS_PATH }}/TestResults/**/*.trx
${{ env.E2E_TESTS_PATH }}/TestResults/**/*-logs.txt
retention-days: 7
117 changes: 0 additions & 117 deletions .github/workflows/e2e-nodejs-langchain.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,121 +66,4 @@ jobs:
-Runtime "nodejs" `
-WorkingDirectory "${{ env.SAMPLE_PATH }}"

- name: Acquire Bearer Token (ROPC)
id: token
shell: pwsh
run: |
$token = & "${{ env.SCRIPTS_PATH }}/Acquire-BearerToken.ps1" `
-ClientId "${{ secrets.MCP_CLIENT_ID }}" `
-TenantId "${{ secrets.MCP_TENANT_ID }}" `
-Username "${{ secrets.MCP_TEST_USERNAME }}" `
-Password "${{ secrets.MCP_TEST_PASSWORD }}"
echo "BEARER_TOKEN=$token" >> $env:GITHUB_OUTPUT
echo "::add-mask::$token"

- name: Copy ToolingManifest.json
shell: pwsh
run: |
& "${{ env.SCRIPTS_PATH }}/Copy-ToolingManifest.ps1" -TargetPath "${{ env.SAMPLE_PATH }}"

- name: Generate .env configuration
shell: pwsh
run: |
$configMappings = @{
"NODE_ENV" = "development"
"AZURE_OPENAI_API_KEY" = "${{ secrets.NODEJS_OPENAI_AZURE_OPENAI_API_KEY }}"
"AZURE_OPENAI_ENDPOINT" = "${{ secrets.NODEJS_OPENAI_AZURE_OPENAI_ENDPOINT }}"
"AZURE_OPENAI_DEPLOYMENT" = "${{ secrets.NODEJS_OPENAI_AZURE_OPENAI_DEPLOYMENT }}"
"AZURE_OPENAI_API_VERSION" = "2024-12-01-preview"
"connections__service_connection__settings__authType" = "ClientSecret"
"connections__service_connection__settings__clientId" = "${{ secrets.NODEJS_OPENAI_AGENT_ID }}"
"connections__service_connection__settings__clientSecret" = "${{ secrets.NODEJS_OPENAI_CLIENT_SECRET }}"
"connections__service_connection__settings__tenantId" = "${{ secrets.TENANT_ID }}"
"connectionsMap__0__serviceUrl" = "*"
"connectionsMap__0__connection" = "service_connection"
"agentic_scopes" = "ea9ffc3e-8a23-4a7d-836d-234d7c7565c1/.default"
}
& "${{ env.SCRIPTS_PATH }}/Generate-EnvConfig.ps1" `
-OutputPath "${{ env.SAMPLE_PATH }}/.env" `
-BearerToken "${{ steps.token.outputs.BEARER_TOKEN }}" `
-Port ${{ env.AGENT_PORT }} `
-ConfigMappings $configMappings

- name: Start Agent
id: start-agent
shell: pwsh
run: |
$agentPid = & "${{ env.SCRIPTS_PATH }}/Start-Agent.ps1" `
-AgentPath "${{ env.SAMPLE_PATH }}" `
-StartCommand "node dist/index.js" `
-Port ${{ env.AGENT_PORT }} `
-BearerToken "${{ steps.token.outputs.BEARER_TOKEN }}" `
-Environment "Development" `
-Runtime "nodejs"
echo "AGENT_PID=$agentPid" >> $env:GITHUB_OUTPUT

- name: Verify Agent Running
shell: pwsh
run: |
$agentPid = "${{ steps.start-agent.outputs.AGENT_PID }}"
if ($agentPid) {
try {
$proc = Get-Process -Id $agentPid -ErrorAction Stop
Write-Host "Agent process (PID: $agentPid) is running: $($proc.ProcessName)" -ForegroundColor Green
} catch {
Write-Host "ERROR: Agent process (PID: $agentPid) is NOT running!" -ForegroundColor Red
throw "Agent process has stopped"
}
}
$agentUrl = "http://localhost:${{ env.AGENT_PORT }}"
$healthResponse = Invoke-WebRequest -Uri "$agentUrl/api/health" -Method GET -UseBasicParsing -ErrorAction SilentlyContinue
Write-Host "Health check: $($healthResponse.StatusCode)" -ForegroundColor Green

- name: Restore E2E Test Dependencies
run: dotnet restore "${{ env.E2E_TESTS_PATH }}/Agent365.E2E.Tests.csproj"

- name: Run .NET E2E Tests
shell: pwsh
run: |
dotnet test "${{ env.E2E_TESTS_PATH }}/Agent365.E2E.Tests.csproj" `
--no-restore `
--verbosity normal `
--logger "console;verbosity=detailed" `
--logger "trx;LogFileName=test-results-nodejs-langchain.trx" `
--filter "Category=HTTP"
env:
AGENT_URL: http://localhost:${{ env.AGENT_PORT }}
TEST_RESULTS_DIR: ${{ runner.temp }}/TestConversations

- name: Emit Test Conversations
if: always()
shell: pwsh
run: |
& "${{ env.SCRIPTS_PATH }}/Emit-TestConversations.ps1" `
-TestResultsDir "${{ runner.temp }}/TestConversations"

- name: Capture Agent Logs
if: always()
shell: pwsh
run: |
& "${{ env.SCRIPTS_PATH }}/Capture-AgentLogs.ps1" `
-AgentPath "${{ env.SAMPLE_PATH }}"

- name: Stop Agent Process
if: always()
shell: pwsh
run: |
$agentPid = "${{ steps.start-agent.outputs.AGENT_PID }}"
if ($agentPid) {
& "${{ env.SCRIPTS_PATH }}/Stop-AgentProcess.ps1" -AgentPID $agentPid
}

- name: Upload Test Results
if: always()
uses: actions/upload-artifact@v4
with:
name: test-results-nodejs-langchain
path: |
${{ env.E2E_TESTS_PATH }}/TestResults/**/*.trx
${{ env.E2E_TESTS_PATH }}/TestResults/**/*-logs.txt
retention-days: 7
Loading
Loading