-
Notifications
You must be signed in to change notification settings - Fork 50
feat: add multiple messages pattern to dotnet agent-framework sample #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0413cf4
feat: add multiple messages pattern to dotnet agent-framework sample
sellakumaran a90150f
fix: address PR review comments in dotnet agent-framework sample
sellakumaran d4ef35a
feat: add multiple-messages pattern (ack + typing loop + LLM response…
sellakumaran 067fdf5
feat: extend multiple-messages pattern to all Python and Node.js samples
sellakumaran d603fab
fix: address Copilot review comments — setInterval async, empty excep…
sellakumaran 4bec681
fix: resolve OboAuthHandlerName null-safety in semantic-kernel sample
sellakumaran f80c0b5
chore: remove internal tracking file from PR
sellakumaran 9dcbf14
Potential fix for pull request finding 'Generic catch clause'
sellakumaran 9610ccf
Potential fix for pull request finding 'Missed ternary opportunity'
sellakumaran a2c3f6b
Potential fix for pull request finding 'Unnecessarily complex Boolean…
sellakumaran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| # Multiple Messages Per Prompt — Issue #268 Tracking | ||
|
|
||
| Tracking implementation of the multiple-messages pattern across all Agent365-Samples. | ||
|
|
||
| **Pattern**: Send an immediate ack message → typing indicator loop → LLM response, all as separate discrete Teams messages. | ||
|
|
||
| > **Reference**: [GitHub Issue #268](https://github.com/microsoft/Agent365-devTools/issues/268) | ||
|
|
||
| --- | ||
|
|
||
| ## Progress | ||
|
|
||
| | Sample | Implementation File | Code | README | Committed | Tested (Agents Playground) | | ||
| |---|---|---|---|---|---| | ||
| | `dotnet/agent-framework` | `Agent/MyAgent.cs` | ✅ | ✅ | ✅ | ✅ | | ||
| | `dotnet/semantic-kernel` | `Agents/MyAgent.cs` | 🔧 | 🔧 | ⏳ | ✅ | | ||
| | `python/agent-framework` | `host_agent_server.py` | 🔧 | 🔧 | ⏳ | ❌ Blocked — `agent_framework` SDK API break (`ChatAgent` removed); pre-existing env issue | | ||
| | `python/openai` | `host_agent_server.py` | ⏳ | ⏳ | ⏳ | ⏳ | | ||
| | `python/claude` | `host_agent_server.py` | ⏳ | ⏳ | ⏳ | ⏳ | | ||
| | `python/crewai` | `host_agent_server.py` | ⏳ | ⏳ | ⏳ | ⏳ | | ||
| | `python/google-adk` | `agent.py` | ⏳ | ⏳ | ⏳ | ⏳ | | ||
| | `nodejs/openai` | `src/agent.ts` | 🔧 | 🔧 | ⏳ | ✅ | | ||
| | `nodejs/claude` | `src/agent.ts` | 🔧 | 🔧 | ⏳ | ⏳ Needs ANTHROPIC_API_KEY | | ||
| | `nodejs/langchain` | `src/agent.ts` | 🔧 | 🔧 | ⏳ | ⏳ | | ||
| | `nodejs/langchain/quickstart-before` | `src/agent.ts` | 🔧 | 🔧 | ⏳ | ✅ | | ||
| | `nodejs/vercel-sdk` | `src/agent.ts` | 🔧 | 🔧 | ⏳ | ⏳ Needs ANTHROPIC_API_KEY | | ||
| | `nodejs/devin` | `src/agent.ts` | 🔧 | 🔧 | ⏳ | ⏳ Needs Devin credentials | | ||
| | `nodejs/perplexity` | `src/agent.ts` | 🔧 | 🔧 | ⏳ | ⏳ Needs PERPLEXITY_API_KEY | | ||
| | `nodejs/copilot-studio` | `src/agent.ts` | 🔧 | 🔧 | ⏳ | ⏳ | | ||
|
|
||
| **Legend**: ✅ Done · 🔧 Modified locally, not committed · ⏳ Pending | ||
|
|
||
| --- | ||
|
|
||
| ## Notes | ||
|
|
||
| - `python/google-adk` uses a different hosting pattern — no shared `host_agent_server.py`; update approach TBD. | ||
| - `nodejs/copilot-studio` was missing the `InstallationUpdate` handler in the constructor — added as part of this work. | ||
| - `nodejs/langchain/quickstart-before` is a pre-refactor snapshot — fixed pre-existing TypeScript errors (`instructions` → `systemPrompt` for langchain 1.2.32+, added `@types/express`/`@types/node`). | ||
| - Node.js samples use a manual `setInterval` typing loop (~4s) even though `startTypingTimer: true` is set in the constructor. The manual loop is necessary for long-running LLM calls that exceed the ~5s typing indicator timeout. | ||
| - Python samples use `asyncio.create_task` for the typing loop since all aiohttp handlers run on the same event loop. | ||
| - C# (`dotnet/semantic-kernel`) uses a single typing indicator (no loop) sent before agent initialization; the streaming informative update takes over as the progress indicator once the LLM call starts. Unlike agent-framework which runs a full `Task.Run` typing loop alongside streaming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.