Add Host IP Check for Deployment#202
Merged
Merged
Conversation
✅ All E2E Tests Passed
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request makes several deployment and configuration improvements to the Python OpenAI sample agent. While the title suggests it focuses on host IP checking for deployment, the changes are broader in scope.
Changes:
- Added Azure App Service detection and host binding configuration (binds to 0.0.0.0 when WEBSITE_HOSTNAME is set)
- Changed
load_dotenv()to useoverride=Trueparameter in both host_agent_server.py and agent.py - Introduced USE_AGENTIC_AUTH environment variable to explicitly control authentication method priority for MCP servers
- Removed duplicate AGENTBLUEPRINT connection configuration from .env.template
- Renamed workflow job from "summary" to "e2e-status" and added explicit status checking logic
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| python/openai/sample-agent/host_agent_server.py | Added Azure App Service host binding logic (0.0.0.0 vs localhost), changed load_dotenv to override=True, improved comments |
| python/openai/sample-agent/agent.py | Changed load_dotenv to override=True, restructured authentication priority with USE_AGENTIC_AUTH flag |
| python/openai/sample-agent/.env.template | Removed duplicate AGENTBLUEPRINT connection settings (lines 28-32 in original) |
| .github/workflows/e2e-orchestrator.yml | Renamed job to e2e-status, added explicit status check step before summary generation |
Comments suppressed due to low confidence (1)
.github/workflows/e2e-orchestrator.yml:118
- There's an inconsistency between the two status check approaches in this job:
- Lines 100-102: Fails if any job has status "failure" or "cancelled" (allows "skipped" and "success")
- Lines 113-118: Fails if any job does NOT have status "success" (fails on "skipped", "failure", "cancelled")
This means the job will:
- Exit with code 1 at line 102 if any job failed/cancelled
- Generate a summary showing "Some Tests Failed" for skipped jobs
The inconsistency is that "skipped" jobs are treated as passing in the first check but failing in the summary generation. Consider aligning both checks to treat "skipped" and "success" as passing states.
if echo "$results" | grep -qE "failure|cancelled"; then
echo "❌ One or more E2E tests failed or were cancelled"
exit 1
fi
echo "✅ All E2E tests passed (or were skipped)"
- name: Generate Summary
if: always()
id: summary
run: |
# Determine overall status
OVERALL_STATUS="✅ All Tests Passed"
if [[ "${{ needs.python-openai.result }}" != "success" ]] || \
[[ "${{ needs.nodejs-openai.result }}" != "success" ]] || \
[[ "${{ needs.nodejs-langchain.result }}" != "success" ]] || \
[[ "${{ needs.dotnet-sk.result }}" != "success" ]] || \
[[ "${{ needs.dotnet-af.result }}" != "success" ]]; then
OVERALL_STATUS="⚠️ Some Tests Failed"
abdulanu0
approved these changes
Jan 30, 2026
mrunalhirve128
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.