Skip to content

Add Host IP Check for Deployment#202

Merged
rahuldevikar761 merged 3 commits into
mainfrom
users/radevika/fixAAuth
Jan 30, 2026
Merged

Add Host IP Check for Deployment#202
rahuldevikar761 merged 3 commits into
mainfrom
users/radevika/fixAAuth

Conversation

@rahuldevikar761

Copy link
Copy Markdown
Collaborator

No description provided.

@rahuldevikar761 rahuldevikar761 requested a review from a team as a code owner January 30, 2026 19:33
Copilot AI review requested due to automatic review settings January 30, 2026 19:33
@github-actions

Copy link
Copy Markdown

✅ All E2E Tests Passed

Sample Status Result
Python OpenAI success
Node.js OpenAI success
Node.js LangChain success
.NET Semantic Kernel success
.NET Agent Framework success

View full test details

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request makes several deployment and configuration improvements to the Python OpenAI sample agent. While the title suggests it focuses on host IP checking for deployment, the changes are broader in scope.

Changes:

  • Added Azure App Service detection and host binding configuration (binds to 0.0.0.0 when WEBSITE_HOSTNAME is set)
  • Changed load_dotenv() to use override=True parameter in both host_agent_server.py and agent.py
  • Introduced USE_AGENTIC_AUTH environment variable to explicitly control authentication method priority for MCP servers
  • Removed duplicate AGENTBLUEPRINT connection configuration from .env.template
  • Renamed workflow job from "summary" to "e2e-status" and added explicit status checking logic

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File Description
python/openai/sample-agent/host_agent_server.py Added Azure App Service host binding logic (0.0.0.0 vs localhost), changed load_dotenv to override=True, improved comments
python/openai/sample-agent/agent.py Changed load_dotenv to override=True, restructured authentication priority with USE_AGENTIC_AUTH flag
python/openai/sample-agent/.env.template Removed duplicate AGENTBLUEPRINT connection settings (lines 28-32 in original)
.github/workflows/e2e-orchestrator.yml Renamed job to e2e-status, added explicit status check step before summary generation
Comments suppressed due to low confidence (1)

.github/workflows/e2e-orchestrator.yml:118

  • There's an inconsistency between the two status check approaches in this job:
  1. Lines 100-102: Fails if any job has status "failure" or "cancelled" (allows "skipped" and "success")
  2. Lines 113-118: Fails if any job does NOT have status "success" (fails on "skipped", "failure", "cancelled")

This means the job will:

  • Exit with code 1 at line 102 if any job failed/cancelled
  • Generate a summary showing "Some Tests Failed" for skipped jobs

The inconsistency is that "skipped" jobs are treated as passing in the first check but failing in the summary generation. Consider aligning both checks to treat "skipped" and "success" as passing states.

          if echo "$results" | grep -qE "failure|cancelled"; then
            echo "❌ One or more E2E tests failed or were cancelled"
            exit 1
          fi
          
          echo "✅ All E2E tests passed (or were skipped)"
      
      - name: Generate Summary
        if: always()
        id: summary
        run: |
          # Determine overall status
          OVERALL_STATUS="✅ All Tests Passed"
          if [[ "${{ needs.python-openai.result }}" != "success" ]] || \
             [[ "${{ needs.nodejs-openai.result }}" != "success" ]] || \
             [[ "${{ needs.nodejs-langchain.result }}" != "success" ]] || \
             [[ "${{ needs.dotnet-sk.result }}" != "success" ]] || \
             [[ "${{ needs.dotnet-af.result }}" != "success" ]]; then
            OVERALL_STATUS="⚠️ Some Tests Failed"

Comment thread python/openai/sample-agent/agent.py
Comment thread python/openai/sample-agent/host_agent_server.py
Comment thread python/openai/sample-agent/agent.py
Comment thread python/openai/sample-agent/host_agent_server.py
Comment thread python/openai/sample-agent/host_agent_server.py
Comment thread python/openai/sample-agent/host_agent_server.py
@rahuldevikar761 rahuldevikar761 enabled auto-merge (squash) January 30, 2026 19:45
@rahuldevikar761 rahuldevikar761 merged commit c8a6fdc into main Jan 30, 2026
34 checks passed
@rahuldevikar761 rahuldevikar761 deleted the users/radevika/fixAAuth branch January 30, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants