Fix python AF sample#191
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Python Agent Framework sample by making authentication optional for local development and improving Azure OpenAI authentication flexibility.
Changes:
- Makes authentication handler configurable via AUTH_HANDLER_NAME environment variable (defaults to None/disabled)
- Adds support for API key authentication as an alternative to Azure CLI credentials for Azure OpenAI
- Simplifies ToolingManifest.json by removing hardcoded URL, scope, and audience fields
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| host_agent_server.py | Adds AUTH_HANDLER_NAME configuration with conditional authentication setup; updates token exchange to only run when auth handler is configured; adds logging for auth status |
| agent.py | Adds AZURE_OPENAI_API_KEY support with fallback to Azure CLI credentials; improves credential selection logging |
| ToolingManifest.json | Removes hardcoded URL, scope, and audience fields, keeping only server name identifiers |
tmlsousa
reviewed
Jan 27, 2026
mrunalhirve128
previously approved these changes
Jan 27, 2026
pontemonti
previously approved these changes
Jan 28, 2026
- Remove unnecessary f-prefix from log messages without interpolation - Add context (tenant_id, agent_id) to observability token log messages - Update type hints to use Optional[str] for auth_handler_name - Document AUTH_HANDLER_NAME in .env.template
rahuldevikar761
dismissed stale reviews from pontemonti and mrunalhirve128
via
9464cf1
mrunalhirve128
approved these changes
Jan 28, 2026
pontemonti
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.