Clean up n8n sample agent as we can now directly use n8n new node#100
Conversation
2ebe3bf to
c636b12
Compare
b1df4c0 to
d5739cf
Compare
|
@rbrighenti I've opened a new pull request, #207, to work on those changes. Once the pull request is ready, I'll request review from you. |
330a830 to
6930e30
Compare
✅ All E2E Tests Passed
|
|
@copilot Please remove the "docs" folder and the ".env.template" file that were added or edited in the "nodejs/n8n/sample-agent" folder after the creation of this PR. The final state of the n8n sample-agent here should be to have only the README and the manifest folder |
|
@rbrighenti I've opened a new pull request, #208, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@microsoft/agent365-approvers Hey approvers. This PR was in Draft for a while, but now ready for review. Please take a look :) |
There was a problem hiding this comment.
Pull request overview
This PR simplifies the n8n sample agent by removing the custom Node.js host implementation and related configuration, and by updating the documentation to guide users toward using n8n’s built‑in Microsoft Agent 365 node instead. The sample now relies entirely on n8n for execution, with this repo primarily providing the manifest and onboarding instructions.
Changes:
- Removed all Node.js/TypeScript source files, build configuration, environment templates, and MCP tooling manifests for the n8n sample agent.
- Deleted detailed code/design documentation that described the previous custom Node.js implementation.
- Rewrote the
README.mdto focus on configuring an Agent 365 blueprint and wiring it to an n8n workflow using the Microsoft Agent 365 node, including permissions and consent steps.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
nodejs/n8n/sample-agent/tsconfig.json |
Removed TypeScript build configuration since the sample no longer uses a Node.js host. |
nodejs/n8n/sample-agent/src/telemetry.ts |
Removed custom observability initialization; observability is now handled via n8n/Microsoft Agent 365 node. |
nodejs/n8n/sample-agent/src/n8nClient.ts |
Removed custom HTTP client that proxied messages to an n8n webhook, as this flow is now handled within n8n. |
nodejs/n8n/sample-agent/src/n8nAgent.ts |
Removed the agent logic class that routed Bot Framework activities to n8n. |
nodejs/n8n/sample-agent/src/mcpToolRegistrationService.ts |
Removed MCP server discovery and tool registration code; MCP tools are now configured directly in the Agent 365 / n8n integration. |
nodejs/n8n/sample-agent/src/index.ts |
Removed Express-based hosting entry point for /api/messages. |
nodejs/n8n/sample-agent/src/agent.ts |
Removed AgentApplication setup and activity handler wiring for the custom agent host. |
nodejs/n8n/sample-agent/package.json |
Dropped Node.js dependencies and scripts since no Node.js runtime is required for this sample anymore. |
nodejs/n8n/sample-agent/docs/design.md |
Deleted design document describing the legacy Node.js architecture in favor of the new n8n-native approach. |
nodejs/n8n/sample-agent/ToolingManifest.json |
Removed MCP tooling manifest now that tooling integration is handled via Agent 365/n8n configuration. |
nodejs/n8n/sample-agent/Agent-Code-Walkthrough.MD |
Deleted detailed code walkthrough for the old implementation. |
nodejs/n8n/sample-agent/.env.template |
Removed environment variable template since the sample no longer runs a separate host. |
nodejs/n8n/sample-agent/README.md |
Replaced Node.js-focused setup instructions with end-to-end guidance for configuring an Agent 365 blueprint, granting permissions, and connecting it to an n8n workflow using the Microsoft Agent 365 node. |
|
@rbrighenti I've opened a new pull request, #209, to work on those changes. Once the pull request is ready, I'll request review from you. |
a77da1b to
8e179d1
Compare
fe4ad55
fe4ad55 to
f583ee3
Compare
@copilot reword the description in the manifest.json given the feedback above |
|
@rbrighenti I've opened a new pull request, #214, to work on those changes. Once the pull request is ready, I'll request review from you. |
@copilot given the feedback above, please remove the line that references the "N8N Sample Design" from the file at nodejs/docs/design.md |
|
@rbrighenti I've opened a new pull request, #215, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * Add minimum n8n version requirement (2.7.0) to README Co-authored-by: rbrighenti <202984599+rbrighenti@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rbrighenti <202984599+rbrighenti@users.noreply.github.com>
* Initial plan * Remove docs folder and .env.template from n8n sample-agent Co-authored-by: rbrighenti <202984599+rbrighenti@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rbrighenti <202984599+rbrighenti@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Initial plan * Fix link text: Microsoft Agents 365 → Microsoft Agent 365 Co-authored-by: rbrighenti <202984599+rbrighenti@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rbrighenti <202984599+rbrighenti@users.noreply.github.com>
* Initial plan * Update README to reference SECURITY.md at repository root Co-authored-by: rbrighenti <202984599+rbrighenti@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rbrighenti <202984599+rbrighenti@users.noreply.github.com>
* Initial plan * Update manifest.json description to reflect n8n-native approach Co-authored-by: rbrighenti <202984599+rbrighenti@users.noreply.github.com> * Apply suggestion from @rbrighenti --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rbrighenti <202984599+rbrighenti@users.noreply.github.com>
* Initial plan * Remove broken link to deleted N8N design document Co-authored-by: rbrighenti <202984599+rbrighenti@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rbrighenti <202984599+rbrighenti@users.noreply.github.com>
0b1b0d3 to
c16177c
Compare
With the new node in n8n released, users no longer need a separate agent application for all the integrations. Everything is built into n8n.
New node in n8n created at: n8n-io/n8n#25145
Summary of changes:
This pull request significantly simplifies the n8n sample agent by removing custom Node.js implementation files and documentation, and updating the README to reflect a new, n8n-native approach using the Microsoft Agent 365 node. The changes focus on eliminating redundant code and configuration, and providing clear, step-by-step instructions for deploying and configuring the agent entirely within n8n, without the need for external code or a custom server.
Major documentation and configuration changes:
Documentation and onboarding simplification:
README.mdto guide users through deploying and configuring the agent using only n8n's Microsoft Agent 365 node, including credential setup, permissions, and workflow design. The new instructions clarify that no external code or compilation is required.Agent-Code-Walkthrough.MD) and the separate design document (docs/design.md), as the custom Node.js implementation is no longer needed. [1] [2]Configuration and code cleanup:
.env.templatefile andToolingManifest.json, removing environment variables and tool configuration that are now handled within n8n. [1] [2]package.jsonfile, eliminating all Node.js dependencies and scripts, since the agent no longer requires a standalone Node.js runtime or build process.These changes streamline the sample agent to rely solely on n8n's built-in capabilities, reducing setup complexity and maintenance overhead.