[GenAI] Fix 11819: updating SimpleHttpRequest.updateCookies to remove existing cookie headers #12147
+103
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roducing multiple Cookie header values when cookies were added one-by-one (while other implementations like the Netty client already behaved).
Jarvx
changed the title
|
I'll close this pr first because the CI fails. |
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| public class CookieHeaderSingleValueTest { |
There was a problem hiding this comment.
test should be placed in where other cookie related tests are keep in the io.micronaut.http.cookie package of the micronaut-http module
There was a problem hiding this comment.
Okay. I'll move it to the folder http/src/test/ . Please understand that it's not easy to find perfect test case for me at the moment. I'll need your feedback for this information.
Jarvx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #11819
Bug description
Calling MutableHttpRequest.cookie(s)is expected to keep a single Cookie header updated. However, multiple Cookie headers are created depending on the request implementation.Root cause & Fix
To fix this with minimal changes, update
SimpleHttpRequest.updateCookies()so that it:ClientCookieEncoder.INSTANCE(consistent with other implementations),HttpHeaders.COOKIE, headerValue).This preserves insertion order via SimpleCookies.getAll() iteration, supports last-writer-wins because SimpleCookies.put replaces by name, and ensures a single header value is maintained for cookies.
Steps to reproduce
Please use this command to see the output from provided test: