change scroll lock module #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibe97
reviewed
Aug 30, 2021
src/index.tsx
Outdated
|
|
||
| const onOpen = useCallback(() => { | ||
| if (preventScroll) { | ||
| if (modalRef.current != null) { |
There was a problem hiding this comment.
@shibe97
Thank you for reviewing.
I used it to mean !== null and !== undefined.
The condition of undefined cannot occur, so it has been fixed.
shibe97
reviewed
Aug 30, 2021
src/index.tsx
Outdated
|
|
||
| const onClose = useCallback(() => { | ||
| if (preventScroll) { | ||
| if (modalRef.current != null) { |
- remove disable-scroll - add body-scroll-lock - Moved optional processing
|
Thank you！ LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change scroll lock module from disable-scroll to body-scroll-lock.
Change
Why
close()useCallback does not work with the button spacebar #27