-
Notifications
You must be signed in to change notification settings - Fork 3
Open shared makecode project #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
We need to think about the URL handling. The key thing is that after the user has imported the project they no longer have the URL with the id in their history. So we need to do a replaceState-style URL update at some point. Otherwise you go back and start an import process again which isn't helpful. |
950e839
to
dcca968
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is working well. Will merge and chat about release timing, translations etc.
This is currently set up to open a shared project if the URL path
Example success page:
https://review-createai.microbit.org/open-shared-makecode-project/_fDpWJaY67cgR
Example error page:
https://review-createai.microbit.org/open-shared-makecode-project/_fdpWJaY67cgR