Skip to content

Conversation

glastonbridge
Copy link
Collaborator

@glastonbridge glastonbridge commented Sep 12, 2025

This is currently set up to open a shared project if the URL path

  • Does not match a predefined app path
  • Begins with an underscore

Example success page:
https://review-createai.microbit.org/open-shared-makecode-project/_fDpWJaY67cgR

Example error page:
https://review-createai.microbit.org/open-shared-makecode-project/_fdpWJaY67cgR

Copy link

github-actions bot commented Sep 12, 2025

@microbit-matt-hillsdon
Copy link

We need to think about the URL handling.

The key thing is that after the user has imported the project they no longer have the URL with the id in their history. So we need to do a replaceState-style URL update at some point. Otherwise you go back and start an import process again which isn't helpful.

@glastonbridge glastonbridge force-pushed the open-shared-makecode-project branch from 950e839 to dcca968 Compare September 23, 2025 14:34
@microbit-matt-hillsdon microbit-matt-hillsdon marked this pull request as ready for review October 2, 2025 15:00
Copy link

@microbit-matt-hillsdon microbit-matt-hillsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is working well. Will merge and chat about release timing, translations etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants