Repository navigation
Cephla: Added autofocus light source shutter. - #766
Merged
Merged
Conversation
Toggles IR light source successfully.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for controlling an autofocus light source (IR laser) in the Cephla device adapter by implementing a new SquidAFShutter class. The implementation mirrors the existing SquidShutter pattern but controls a different hardware pin (MCU_PINS_AF_LASER).
Key Changes:
- Created a new
SquidAFShutterclass to control the autofocus IR laser - Added device registration and factory methods for the new shutter
- Enhanced logging in the monitoring thread
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| SquidAFShutter.cpp | New file implementing the autofocus shutter device controlling pin 15 |
| Squid.h | Added class declaration for SquidAFShutter and required constants |
| SquidHub.cpp | Registered the new AF shutter device and added it to detected peripherals |
| SquidShutter.cpp | Removed commented-out code from Initialize() |
| SquidMonitoringThread.cpp | Uncommented and added logging statements |
| Cephla.vcxproj | Added new source file to build configuration |
| Cephla.vcxproj.filters | Added new source file to project filters |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toggles IR light source successfully.