Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Fixed a bug where the default MySQL backup command would attempt to use credentials from `~/.my.cnf` if it exists, instead of Craft’s configured database connection settings.
  • Loading branch information
angrybrad committed Nov 21, 2022
1 parent 1d7c8e0 commit c1068dd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- `craft\base\Element::includeSetStatusAction()` now returns `false` by default regardless of what `hasStatuses()` returns, fixing a bug where some element indexes were unexpectedly getting “Set Status” actions.
- Query conditions generated by `craft\helpers\Db::parseParam()` no longer account for `null` values, due to a heavy performance impact. ([#11931](https://github.com/craftcms/cms/issues/11931))
- Fixed a bug where the default MySQL backup command would attempt to use credentials from `~/.my.cnf` if it exists, instead of Craft’s configured database connection settings. ([#12349](https://github.com/craftcms/cms/issues/12349))
- Updated Yii to 2.0.47.

## 4.3.3 - 2022-11-17
Expand Down
2 changes: 1 addition & 1 deletion src/db/mysql/Schema.php
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ public function createColumnSchemaBuilder($type, $length = null): ColumnSchemaBu
public function getDefaultBackupCommand(?array $ignoreTables = null): string
{
$defaultArgs =
' --defaults-extra-file="' . $this->_createDumpConfigFile() . '"' .
' --defaults-file="' . $this->_createDumpConfigFile() . '"' .
' --add-drop-table' .
' --comments' .
' --create-options' .
Expand Down

0 comments on commit c1068dd

Please sign in to comment.