Skip to content

Commit

Permalink
Fixed tab switching bug
Browse files Browse the repository at this point in the history
  • Loading branch information
brandonkelly committed Nov 30, 2022
1 parent aa00cea commit 926bd27
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Release Notes for Craft CMS 4

## Unreleased

- Fixed a bug where entry tab contents could remain visible when switching to other tabs, after changing the entry type.

## 4.3.4 - 2022-11-29

- The `serve` command now routes requests for nonexistent files to Craft. ([#12310](https://github.com/craftcms/cms/pull/12310))
Expand Down
2 changes: 1 addition & 1 deletion src/models/FieldLayoutTab.php
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ public function setElements(array $elements): void
public function getHtmlId(): string
{
// Use two dashes here in case a tab name starts with “Tab”
return 'tab--' . StringHelper::toKebabCase($this->name);
return 'tab--' . StringHelper::toKebabCase(StringHelper::toAscii($this->name, 'en'));
}

/**
Expand Down

0 comments on commit 926bd27

Please sign in to comment.