fix(release): repair package.json scripts orphaned by PR #746 - #747
Merged
Conversation
2b512b6 (PR #746) deleted manifest-beta.json and version-bump-beta.mjs but did NOT include the package.json change that stops referencing them, so `bun run version:beta` on main has been broken since that merge — it invokes a script that no longer exists. Cause: the staging command listed already-`git rm`'d paths alongside modified ones. git aborted the whole `add` with "fatal: pathspec 'manifest-beta.json' did not match any files", so only the two pre-staged deletions made it into the commit. The accompanying edits were written to disk but never staged, and went unnoticed because `git status` wasn't re-checked after committing. Restores the intended changes: - package.json: version:beta bumps manifest.json like version:prod; release:beta pushes the current branch instead of hardcoded main:main - .github/workflows/release.yml: comment explains why there's no beta manifest to publish (BRAT v1.1.0+ ignores manifest-beta.json) - AGENTS.md: documents the unified bump mechanics - CHANGELOG.md: Build entries for all of the above Also extends CI to 1.12-compat. For push events GitHub uses the workflow file from the branch being pushed, so 1.12-compat needs its own copy listing itself; both files now list both branches so they stay identical and future ports are mechanical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis currently broken —bun run version:betainvokesversion-bump-beta.mjs, which PR #746 deleted. This restores the half of that change which never made it into the commit, and adds the1.12-compatCI trigger.What went wrong
PR #746 was supposed to contain two deletions plus five file edits. It merged with only the deletions:
The staging command listed already-
git rm'd paths alongside modified ones, so git aborted the entireadd:Only the two pre-staged deletions were committed.
git statuswasn't re-checked afterwards, so it went out as-is. (The identical mistake happened on1.12-compatand was caught there, fixed by5ada704.)Restored
package.json—version:betabumpsmanifest.jsonlikeversion:prod;release:betapushes the current branch instead of hardcodedmain:main.github/workflows/release.yml— comment explaining there's no beta manifest to publish (BRAT v1.1.0+ ignoresmanifest-beta.json)AGENTS.md— documents the unified bump mechanicsCHANGELOG.md— Build entriesPlus: CI on
1.12-compatFor
pushevents GitHub uses the workflow file from the branch being pushed, so1.12-compatneeds its own copy listing itself — listing it only inmain's file would do nothing. Both files now list both branches, so they stay byte-identical and future ports are mechanical.bun run build && bun run testpass (382 tests, 0 type errors, svelte-check 0/0), andversion:betanow resolves to a script that exists.