-
Notifications
You must be signed in to change notification settings - Fork 4
Non intrusive changes to get some SAMD board working. #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LongDirtyAnimAlf
wants to merge
12
commits into
michael-ring:master
Choose a base branch
from
LongDirtyAnimAlf:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ebf8533
Added SAMD10XMini as Blinky sample
LongDirtyAnimAlf cfd7917
Blinky working on D20Xplained.
LongDirtyAnimAlf 564529d
Display abstraction
LongDirtyAnimAlf d431370
MBED working
LongDirtyAnimAlf b238ef8
Assembler bugfix
LongDirtyAnimAlf 5bf56a4
ADC working on SAMC21
LongDirtyAnimAlf 4857f9a
Added MMA7660 sensor into MBED demo
LongDirtyAnimAlf e81bcd8
Added OLED example
LongDirtyAnimAlf 061cfc5
Added SAMD20 as target for display demo.
LongDirtyAnimAlf 3876d93
Added some compatibility defines into systemcore for cortexm0
LongDirtyAnimAlf 7744bd8
UART for SAMCD
LongDirtyAnimAlf dff958d
SAMC CPU scaling for RC and PLL working.
LongDirtyAnimAlf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -232,7 +232,9 @@ procedure WaitSYSCTRL; | |
| SYSCTRL_DFLLCTRL_QLDIS; // 1 = Disable quick lock. | ||
|
||
| {$else} | ||
| SYSCTRL_DFLLCTRL_CCDIS OR | ||
| {$ifdef has_usb} | ||
| SYSCTRL_DFLLCTRL_USBCRM OR //* USB correction */ | ||
| {$endif} | ||
| SYSCTRL_DFLLCTRL_BPLCKC; | ||
| {$endif} | ||
| WaitSYSCTRL; | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the right way to do things. Better define a const LED (and LED0) with value TNativePin.PA14.
You should not 'kill' the ArduinoPins Definition for the sake of making Blinky run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fully agreed.
But the current Blinky used this Arduino-pin, and the board itself has no Arduino pins.
Please correct me if I am wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a look here:
http://www.microchip.com/DevelopmentTools/ProductDetails/atardadpt-xpro
The shield is a little difficult to find when you do not know what to search for
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha !
Did not know of this adapter-board !
Nice addition.
Surely, the Arduino pin-definitions must be included.