Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): Add support for reading __NSCFData key strings #32

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mold
Copy link

@mold mold commented Jan 21, 2020

Fixes a crash caused by reading incorrectly encoded key strings on iOS.

Original PR description here: Crypho#154 (the previous maintainer chose not to merge it, hoping it will get merged this time 🤞)

Thanks for keeping this plugin alive!

@BorntraegerMarc
Copy link

I kind of agree with the original statement:

Since this is not very useful for anybody else, I am reluctant to merge. I would suggest you have a migration that checks the existing keys and migrates them before initialising secure storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants