New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CMakeLists and update enum handling for improved clarity and… #3

Merged

mguludag merged 1 commit into main from fixed_string_experiment

Feb 9, 2025

Owner

mguludag commented Feb 8, 2025

… consistency

trunk-io bot commented Feb 8, 2025 •

edited

Loading

⏱️ 6h 24m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
Trunk Check Runner	3h 31m	🟥 ⬜ 🟥 🟥 🟥 (+22 more)
Analyze (c-cpp)	28m	🟩 🟩 🟩 🟩 🟩 (+9 more)
windows-build (23)	15m	🟩 🟩 🟩 🟩 🟩 (+9 more)
windows-build (17)	14m	🟩 🟩 🟩 🟩 🟩 (+9 more)
windows-build (20)	13m	🟩 🟩 🟩 🟩 🟩 (+9 more)
windows-build (11)	13m	🟩 🟩 🟩 🟩 🟩 (+9 more)
clang 11 (C++11, Release)	9m	🟩 🟩 🟩 🟩 🟩 (+9 more)
clang 11 (C++17, Release)	9m	🟥 🟥 🟥 🟩 🟩 (+9 more)
clang 15 (C++20, Release)	9m	🟩 🟩 🟩 🟩 🟩 (+9 more)
clang 11 (C++14, Release)	9m	🟩 🟩 🟩 🟩 🟩 (+9 more)
clang 12 (C++17, Debug)	8m	🟩 🟩 🟩 🟩 🟩 (+9 more)
clang 11 (C++17, Debug)	8m	🟥 🟥 🟥 🟩 🟩 (+9 more)
gcc 12 (C++20, Release)	7m	🟥 🟩 🟩 🟩 🟩 (+9 more)
gcc 9 (C++14, Release)	7m	🟩 🟩 🟩 🟩 🟩 (+9 more)
gcc 9 (C++17, Release)	7m	🟩 🟩 🟩 🟩 🟩 (+9 more)

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

mguludag force-pushed the fixed_string_experiment branch 12 times, most recently from 7398703 to c09af08 Compare

February 9, 2025 04:59


          Refactor CMakeLists and update enum handling for improved clarity and…

a415cdc

… consistency

mguludag force-pushed the fixed_string_experiment branch from c09af08 to a415cdc Compare

February 9, 2025 05:05

mguludag commented

View reviewed changes

Owner Author

mguludag left a comment

since fixed_string is introduced and adjusted the code according to it, then it looks good for achieving the constexpr on c++14 is good to have

mguludag merged commit 54b309c into main

18 of 21 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet