update with original #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed broken ldap3 requirement
Nice catch @cnotin! Merging: smbserver.py: fix order of "computer\username" in log messages
- Thought I already did it but there are some use cases that weren't working, so a more safer approach is taken now (i.e. converting everything to binary at the very beginning) - This should address #628
…nition in the RFC 3397
Adjust the option domain-search-list to be synchronized with its definition in the RFC 3397
- We should actually do what we meant. - Should address #631
- Changed enable_signing for set_session_key as previously used - MIC calculations are stored using the original type3 message, in order to avoid changes when marshaling back again using impacket.
Mic remove - CVE-2019-1040
Also handling raw buffers in dtypes.STR.__getitem__()
Adjust 5257b9d changes to dtypes.STR to work in Python 2 & 3
- Plus fixing bug that wasn't showing the domain we're connecting when using the NETLOGON approach to get signing keys
and for testing KDC handling S4U2Self with unkeyed checksum. See CVE-2018-16860 and CVE-2019-0734 Signed-off-by: Isaac Boukris <[email protected]>
A tool for testing CVE-2018-16860 and CVE-2019-0734
- chmod +x - Adding exec #! - Adding impacket banner - Fixing code style proposed by pyCharm
…cket into stuken-nested_obj_value_fix
rpctransport.getRemoteName() could be anything that user specified
Windows usernames are case insensitive. In smbserver credentials are stored in the server in the exact manner they are provided by the user and fetched using the username provided in the AUTH message as the key of the dictionnary. If there is a difference in the case, credentials are not found and the authentication fails.
…the config file. Related to #833
Some exploitations or techniques that activate the NTLMrelay, like printerbug.py, have special behaviors that affect the correct functioning of LDAP attacks. This commit fix an issue related to those incoming connections.
Windows 10, version 1709, Windows 10, version 1903, Windows Server, version 1709, Windows Server, version 1903, and later versions of Windows, have Guest access in SMB2 disabled by default. This commit adds a trick to avoid this restriction.
Ntlmrelay.px fixes
…results_control fix the ldap search with paged results
Missing byte literal string annotation added.
Replaced deprecated getheader() with get()
Added python2 support
Fixed missing byte literal and deprecated getheader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.