This repository was archived by the owner on Jul 18, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
feat: filtros de facetados via -f/--filtros #10
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For any non-persona facet, e.g.
--filtros iva:iva_exento, CUIT Online's own facet links use a different parameter (f1[]for IVA, with other facets under f0/f2/f4/f6), but this parser always submits every user-provided filter asf5[]. As a result, the advertised IVA/ganancias/monotributo filters are not applied correctly; only tipo-persona filters can work. The parser needs to keep or infer the correct facet key instead of hard-codingf5[]for all filters.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resuelto con el dict
_FACETA_A_PARAMque mapea cada faceta a su parámetro correcto (iva→f1[],monotributo→f2[],ganancias→f3[],empleador→f4[],persona→f5[],nacionalidad→f6[]). Los mapeos se verifican con tests unitarios enTestParsearFiltros.