Repository navigation
fix(web-server): treat a blank chat session id as missing - #795
Merged
Merged
Conversation
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
2 tasks done
justintime4tea
force-pushed
the
justingross/fix-blank-chat-session-id
branch
from
October 9, 2026 00:48
67bfcc3 to
03337ac
Compare
justintime4tea
marked this pull request as ready for review
October 9, 2026 00:50
A client that sent an empty chat session id, in its metadata or either session header, had it taken as given. Every such client then shared one session, and with it each other's recorded skill invocations, since the skill store keys a session by its string; orchestration persistence refused the empty id outright and failed the request. A blank value now counts as none given and falls through to the next source, and a request with no non-blank id gets a fresh one, as a request that names no session does. Fixes: GH-799
justintime4tea
force-pushed
the
justingross/fix-blank-chat-session-id
branch
from
October 9, 2026 00:52
03337ac to
bde1a6a
Compare
This was referenced Oct 9, 2026
dhable
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A blank chat session id in the request metadata or either session header was taken as given, so every client sending one shared a session and its recorded skill invocations, and orchestration persistence refused it outright. A blank value now falls through to the next source, and a request with no non-blank id gets a fresh one.
Verification
cargo +nightly fmt --check,cargo clippy --workspace --all-targets --all-features -- -D warnings, andcargo test --workspace(2,547 passed) onnightlyat513f1ec1.Fixes: GH-799