Swagger with spec record (cljs support) #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the problem is in clojurescript, because records don't implement the protocol: https://dev.clojure.org/jira/browse/CLJS-1297 |
nenadalm
changed the title
nenadalm
commented
Sep 19, 2018
| :description "", | ||
| :required true, | ||
| :schema {:type "object", | ||
| ;; :title "spec-tools.swagger.core-test/address", |
There was a problem hiding this comment.
Is this intentional? If spec is used instead of spec records, the :title is present.
There was a problem hiding this comment.
I think the title should be present in both.
|
Thanks, will fix the title and push out a release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I was playing with reitit and Macchiato (macchiato-framework/macchiato-core#7) but I am not sure how to generate spec. I've tried to follow guide for ring (https://metosin.github.io/reitit/ring/swagger.html).
It looks like reitit is converting given spec in
:parametersinto spec records and then I get following error in cljs:it comes from this function:
spec-tools/src/spec_tools/swagger/core.cljc
Line 136 in cb4b448
It seems to sort of work for clj, the result is just a bit different with spec records in the test (added test is just copy-paste of the test above, just with converted spec to spec records). Spec record is missing
:titlekey inbody.schema.