Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor tweaks #21

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Minor tweaks #21

merged 1 commit into from
Aug 23, 2022

Conversation

mikemaccana
Copy link
Contributor

  • Highlight this works with any Vite supported framework
  • Clarify we're adding packages for the browser for node.js features (instead of saying we're adding npm packages that are not available in the browser, which was confusing)
  • Flag a couple of places where the instructions differ per framework.

@mikemaccana
Minor tweaks
e8f00cb 
 - Highlight this works with any Vite supported framework
 - Clarify we're adding packages for the browser for node.js features (instead of saying we're adding npm packages that are not available in the browser, which was confusing)
 - Flag a couple of places where the instructions differ per framework.
@lorisleiva lorisleiva merged commit d44fc17 into metaplex-foundation:main Aug 23, 2022
@lorisleiva
Copy link
Contributor

Cheers for that! 🍺

@mikemaccana mikemaccana deleted the patch-1 branch August 23, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikemaccana @lorisleiva