-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hook execve
and execv
to allow shared sockets.
#2610
Merged
aviramha
merged 76 commits into
metalbear-co:main
from
meowjesty:issue/864/copy-sockets
Jul 30, 2024
Merged
Hook execve
and execv
to allow shared sockets.
#2610
aviramha
merged 76 commits into
metalbear-co:main
from
meowjesty:issue/864/copy-sockets
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitryDodzin
requested changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes regarding sip but looks good otherwise =]
DmitryDodzin
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now share the
SOCKETS
created by the parent process with its children (yay happy family) through an env varMIRRORD_SHARED_SOCKETS
(the creativity is astonishing) that is set up inexec*
calls (and alsoposix_spawn
for macos). TheSOCKETS
are rebuilt from this env var (if it exists) in the child process.execv
for linux;set_var
;execve
hook also available on linux;execve
behaviour to insert a new env var before callingFN_EXECVE
;uvicorn
app with the--reload
flag, which triggers the issue;