Vpn #2607
Merged
Vpn #2607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razz4780
reviewed
Jul 22, 2024
Razz4780
requested changes
Jul 22, 2024
There was a problem hiding this comment.
Four concerns, mostly:
- Gotta improve error handling :V
- Gotta add
mirrord-protocolversion requirement and version negotiation. - I'm not sure about DNS resolver config cleanup - afraid of leaving garbage behind when the user kills mirrord process.
- What happens if the user runs
mirrord vpnconcurrently? We should probably catch this case and warn/abort/make sure that we don't mess up DNS config
Razz4780
requested changes
Aug 19, 2024
Co-authored-by: Michał Smolarek <[email protected]>
Razz4780
requested changes
Aug 21, 2024
Co-authored-by: Michał Smolarek <[email protected]>
Razz4780
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very basic and alpha version for
mirrord vpn