Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't filter outgoing traffic to target #2588

Merged
merged 6 commits into from
Jul 17, 2024

Conversation

DmitryDodzin
Copy link
Member

@DmitryDodzin DmitryDodzin commented Jul 11, 2024

Updated so if requests comes from target address don't fliter them out in our OUTPUT chain

closes #2572

@DmitryDodzin DmitryDodzin marked this pull request as ready for review July 11, 2024 10:58
@Razz4780 Razz4780 self-requested a review July 11, 2024 11:35
Copy link
Contributor

@Razz4780 Razz4780 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can it possibly work without filtering by gid? 👀

mirrord/agent/src/steal/ip_tables/output.rs Outdated Show resolved Hide resolved
@DmitryDodzin DmitryDodzin force-pushed the issue/2572/iptables-update branch from c1085da to 9be23ce Compare July 15, 2024 18:13
mirrord/agent/src/cli.rs Outdated Show resolved Hide resolved
@DmitryDodzin DmitryDodzin changed the title Don't filter by gid in OUTPUT Don't filter outgoing traffic to target Jul 16, 2024
Copy link
Member

@aviramha aviramha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving changes requested by me - still need additional approval.

Copy link
Contributor

@Razz4780 Razz4780 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ^^

@DmitryDodzin DmitryDodzin added this pull request to the merge queue Jul 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 16, 2024
@aviramha aviramha added this pull request to the merge queue Jul 17, 2024
Merged via the queue into metalbear-co:main with commit 1323a14 Jul 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outgoing connections to same service are not stolen
3 participants