-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend operator headers #2550
Extend operator headers #2550
Conversation
We don't want a license to be needed for the non actual usage APIs. It should be fallible and optional. |
Do you mean operator license or user license? |
I meant user license but we shouldn't check the operator license for getting it's status anyway |
So, summarizing:
Correct? |
I'd add the user license to the status too, just make it optional. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think operator api can be a changed bit to prevent any issues that may happen post future changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would double check that the progress bar isn't a bit much but other than that looks good =]
Closes #2466
CLI version and user name/hostname headers are sent with all operator requests.
Client certificate header:
mirrord operator status
: we don't know operator license fingerprint before getting the resource, so header is not sent.mirrord exec
: as soon as we get the operator resource, we prepare the client cert header. If we fail, command aborts.mirrord ls
/mirrord operator session
: as soon as we get the operator resource, we try to prepare the client cert header. If we fail, we continue without itI kind of went full aggro on the operator client code and made more changes than necessary :V
mirrord ls
the extra discovery step present inmirrord exec
(Improve operator discovery UX (CLI) #2487)